MudThemeProvider: Set clearer boundary between MudThemeProvider and M… #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udTheme regarding palettes
Codecov Report
@@ Coverage Diff @@
## dev #3654 +/- ##
=======================================
Coverage 90.37% 90.38%
=======================================
Files 333 333
Lines 10487 10545 +58
=======================================
+ Hits 9478 9531 +53
- Misses 1009 1014 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting clearer boundaries between
MudThemeandMudThemeProviderDescription
Currently, there is a bit of confusion between the
IsDarkModeproperty of aMudThemeand the propertyIsDarkModeof theMudThemeProvider. The latter can create a condition where the dark mode is enabled in the Themeprovider but not in the theme itself, which creates "unstable" rendering. With this PR, the theme itself is only providing a dark palette but the ThemeProvider "decides" if it should be used.How Has This Been Tested?
Visually. Unit tests were neither changed nor newly created. This will be done when there is a major change regarding themes.
Checklist:
✔️ The PR is submitted to the correct branch (
dev).✔️ My code follows the code style of this project.
❌ I've added relevant tests.