Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumericField: Fix not updating value from text on blur when debounced #3653

Merged
merged 2 commits into from
Jan 2, 2022

Conversation

rogue6800
Copy link
Contributor

@rogue6800 rogue6800 commented Jan 2, 2022

Description

Fixes #3651 - Numeric field with debounce interval doesn't apply change when the field loses focus.

Update the value before updating the text formatting on losing focus (on blur) of debounced numeric fields.

How Has This Been Tested?

Unit tests all pass. Also tested via demo in docs.

Checklist:

✔️ The PR is submitted to the correct branch (dev).
✔️ My code follows the code style of this project.
❌ I've added relevant tests.

  • No Tests Added

@mudbot mudbot bot added bug Something does not work as intended/expected needs review labels Jan 2, 2022
@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #3653 (8051c95) into dev (4677eec) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3653      +/-   ##
==========================================
+ Coverage   90.37%   90.38%   +0.01%     
==========================================
  Files         333      333              
  Lines       10487    10488       +1     
==========================================
+ Hits         9478     9480       +2     
+ Misses       1009     1008       -1     
Impacted Files Coverage Δ
...r/Components/NumericField/MudNumericField.razor.cs 97.35% <100.00%> (+0.01%) ⬆️
...udBlazor/Services/KeyInterceptor/KeyInterceptor.cs 74.19% <0.00%> (ø)
...rc/MudBlazor/Components/Input/MudDebouncedInput.cs 89.58% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4677eec...8051c95. Read the comment docs.

@mikes-gh
Copy link
Contributor

mikes-gh commented Jan 2, 2022

Look good to me @henon?

@henon henon removed the needs review label Jan 2, 2022
@henon henon changed the title Fixed debounced numeric field not updating value from text on blur. Fixes issue #3651 NumericField: Fix not updating value from text on blur when debounced Jan 2, 2022
@Garderoben Garderoben added this to the 6.0.4 milestone Jan 2, 2022
@Garderoben Garderoben merged commit 46d9b73 into MudBlazor:dev Jan 2, 2022
@rogue6800 rogue6800 deleted the NumericDebounceBlurFix branch January 3, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numeric field with debounce interval doesn't apply change when the field loses focus
4 participants