Build: Add node requirement to CONTRIBUTING.md. #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
@henon and @mikes-gh, I believe listing a dependency on NodeJS will merely create confusion in the sense it will be judged as a hard dependency that people will think they have to install on their systems. It is as unnecessary to mention a a NodeJS dependency as it is to mention a TypeScript compiler dependency, or WebCompiler dependency. All these are internal requirements resolved automatically at build time by MSBuild. Just saying, you guys can keep the dependency list as clean as before. |
|
You need node to build from source no? Did I get that wrong? |
mikes-gh
changed the title
mikes-gh
pushed a commit
to mikes-gh/MudBlazor
that referenced
this pull request
Jan 3, 2022
This reverts commit f1e65cd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add node requirement to docs.
Description
Changing to the package
Microsoft.TypeScript.MSBuildgives us better compilation and ES6 support.It does however require node.
The tradeoff is acceptable because it is only required to build from source.
How Has This Been Tested?
None
Docs change
Checklist:
✔️ The PR is submitted to the correct branch (
dev).✔️ My code follows the code style of this project.