Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Chart Options to allow for configuring stroke-width - resolves issue #3536 #3645

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

rogue6800
Copy link
Contributor

@rogue6800 rogue6800 commented Jan 1, 2022

Description

Adds stroke-width to Chart Options to allow for custom line width on a line chart.

How Has This Been Tested?

Tested visually as the line chart only has limited unit testing currently and implementing more tests is out of the scope of this work.

image

Checklist:

✔️ The PR is submitted to the correct branch (dev).
✔️ My code follows the code style of this project.
I've added relevant tests.

@mudbot mudbot bot added enhancement New feature or request needs review labels Jan 1, 2022
@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #3645 (d3c5834) into dev (3c81cf6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3645   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files         333      333           
  Lines       10487    10487           
=======================================
  Hits         9478     9478           
  Misses       1009     1009           
Impacted Files Coverage Δ
.../MudBlazor/Components/Chart/Models/ChartOptions.cs 100.00% <ø> (ø)
src/MudBlazor/Components/Chart/Charts/Line.razor 90.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c81cf6...d3c5834. Read the comment docs.

@rogue6800 rogue6800 marked this pull request as ready for review January 1, 2022 17:40
@Garderoben Garderoben added this to the 6.0.4 milestone Jan 2, 2022
@Garderoben Garderoben merged commit d70a2e4 into MudBlazor:dev Jan 2, 2022
@rogue6800 rogue6800 deleted the ChartStrokeWidth branch January 3, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants