Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix arc closepath #3295

Merged
merged 4 commits into from Oct 13, 2021
Merged

Bugfix arc closepath #3295

merged 4 commits into from Oct 13, 2021

Conversation

Bl4sio
Copy link
Contributor

@Bl4sio Bl4sio commented Oct 10, 2021

Fix for #3293
A drawLine is called to the start of an arc.
Unit tests updated.

HackbrettXXX
HackbrettXXX requested changes Oct 11, 2021
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The CI failures seem to be due to floating point differences. You can probably fix them by passing floatPrecision: 2 to the jsPDF constructor.

@Bl4sio
Copy link
Contributor Author

Bl4sio commented Oct 13, 2021

I added the floatPrecision: 3 to the failing test case. And updated the reference pdf as well. The test was passing for me locally.

HackbrettXXX
HackbrettXXX approved these changes Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks, I'll merge it.

@HackbrettXXX HackbrettXXX merged commit af2d39d into parallax:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HackbrettXXX HackbrettXXX HackbrettXXX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bl4sio @HackbrettXXX