Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: lineWidth is a negative number #3132

Merged
merged 1 commit into from Apr 7, 2021
Merged

Fix: lineWidth is a negative number #3132

merged 1 commit into from Apr 7, 2021

Conversation

zhangshine
Copy link
Contributor

According to PDF reference 1.3 - 4.3.2

The line width parameter specifies the thickness of the line used to stroke a path. It is a nonnegative number expressed in user space units;

@zhangshine zhangshine changed the title lineWidth should be nonnegative Fix lineWidth is negative number Apr 7, 2021
@zhangshine zhangshine changed the title Fix lineWidth is negative number Fix: lineWidth is a negative number Apr 7, 2021
HackbrettXXX
HackbrettXXX approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good!

@HackbrettXXX HackbrettXXX merged commit cbc85b4 into parallax:master Apr 7, 2021
sthagen added a commit to sthagen/parallax-jsPDF that referenced this pull request Apr 11, 2021
@sthagen
Merge pull request #7 from MrRio/master
1a93365 
lineWidth should be nonnegative (parallax#3132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HackbrettXXX HackbrettXXX HackbrettXXX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhangshine @HackbrettXXX