Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event for start printing row and cell #3039

Merged
merged 12 commits into from Sep 10, 2021
Merged

Event for start printing row and cell #3039

merged 12 commits into from Sep 10, 2021

Conversation

mojtaba-khallash
Copy link
Contributor

Fix #3038

@HackbrettXXX
Copy link
Collaborator

Lets discuss my #3038 (comment), before I merge this.

@nielsnl68
Copy link

I like this future, the only issue i have with it is that you assume that both rowStart and cellStart are a function.
Please consider changing if (config.rowStart) {...} etc into if (("rowStart" in config) && (typeof config.rowStart ==="function") {...}

@mojtaba-khallash
Copy link
Contributor Author

I hope @HackbrettXXX accept to merge :)

Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll merge the PR.

  • please add the new API to the typings
  • We might pass the jsPDF document as second parameter to the callback functions. What do you think?

Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks!

@HackbrettXXX HackbrettXXX merged commit 574c6f0 into parallax:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event for start printing row and cell
3 participants