Skip to content

(🎁) Error on pinned without latest #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

KotlinIsland
Copy link
Contributor

@KotlinIsland KotlinIsland commented Feb 8, 2023

@MousaZeidBaker
Copy link
Owner

Great improvement!

Copy link
Owner

@MousaZeidBaker MousaZeidBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git commit --amend -m "fix: throw error on pinned without latest"
  • Fix other linting errors src/poetry_plugin_up/command.py:38:81: E501 line too long (87 > 80 characters), see ci logs

Sorry, something went wrong.

@KotlinIsland
Copy link
Contributor Author

KotlinIsland commented Feb 10, 2023

Why is your line length set to 80? pep 8 says 79, but black defaults to 88 (which I prefer)

@MousaZeidBaker
Copy link
Owner

Why is your line length set to 80? pep 8 says 79, but black defaults to 88 (which I prefer)

80 is the "industry standard" for most programming languages, whether it's 79 or 80, doesn't matter much as long as we are consistent.

@MousaZeidBaker MousaZeidBaker merged commit 9424d14 into MousaZeidBaker:master Feb 10, 2023
@KotlinIsland KotlinIsland deleted the feat/pinned branch February 10, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(📚) Improve documentation for --pinned
2 participants