Skip to content
This repository has been archived by the owner on Mar 7, 2020. It is now read-only.

Kill the last mutants! #170

Closed
3 tasks
loic425 opened this issue Apr 3, 2019 · 1 comment · Fixed by #188
Closed
3 tasks

Kill the last mutants! #170

loic425 opened this issue Apr 3, 2019 · 1 comment · Fixed by #188
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Comments

@loic425
Copy link
Member

loic425 commented Apr 3, 2019

Describe the proposed solution
Monofony Infection scoring must be equal to 100% in order to start your projects with the highest level as possible and allow you to keep this 100% along your development.

  • src/Form/EventSubscriber/AddUserFormSubscriber.php:48
  • src/Form/EventSubscriber/AddUserFormSubscriber.php:49
  • src/Form/Extension/DateTypeExtension.php:28

Waiting for this infection issue:
infection/infection#655

@loic425
Copy link
Member Author

loic425 commented Apr 3, 2019

Escaped mutants:

Timed Out mutants:

Not Covered mutants:

  1. /Users/loic/www/monofony/src/Entity/IdentifiableTrait.php:34 [M] PublicVisibility

--- Original
+++ New
@@ @@
/**
* @return int
*/

  • public function getId()
  • protected function getId()
    {
    return $this->id;
    }
    }
  1. /Users/loic/www/monofony/src/Form/EventSubscriber/AddUserFormSubscriber.php:48 [M] FalseValue

--- Original
+++ New
@@ @@
{
$form = $event->getForm();
$form->add('user', $this->entryType, ['constraints' => [new Valid()]]);

  •    $form->add('createUser', CheckboxType::class, ['label' => 'app.ui.create_user', 'required' => false, 'mapped' => false]);
    
  •    $form->add('createUser', CheckboxType::class, ['label' => 'app.ui.create_user', 'required' => true, 'mapped' => false]);
    
    }
    /**
    * @param FormEvent $event
  1. /Users/loic/www/monofony/src/Form/EventSubscriber/AddUserFormSubscriber.php:49 [M] FalseValue

--- Original
+++ New
@@ @@
{
$form = $event->getForm();
$form->add('user', $this->entryType, ['constraints' => [new Valid()]]);

  •    $form->add('createUser', CheckboxType::class, ['label' => 'app.ui.create_user', 'required' => false, 'mapped' => false]);
    
  •    $form->add('createUser', CheckboxType::class, ['label' => 'app.ui.create_user', 'required' => false, 'mapped' => true]);
    
    }
    /**
    * @param FormEvent $event
  1. /Users/loic/www/monofony/src/Form/Extension/DateTypeExtension.php:28 [M] FalseValue

--- Original
+++ New
@@ @@
*/
public function configureOptions(OptionsResolver $resolver)
{

  •    $resolver->setDefaults(['widget' => 'single_text', 'html5' => false, 'format' => 'dd/MM/yyyy']);
    
  •    $resolver->setDefaults(['widget' => 'single_text', 'html5' => true, 'format' => 'dd/MM/yyyy']);
    
    }
    /**
    * {@inheritdoc}

@loic425 loic425 changed the title Infection scoring to 100% Kill the last mutants! Apr 3, 2019
@loic425 loic425 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Apr 3, 2019
@loic425 loic425 mentioned this issue May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant