Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Gradle Wrapper files in CI / Github Action #207

Open
emanuelb opened this issue May 6, 2020 · 0 comments
Open

Verify Gradle Wrapper files in CI / Github Action #207

emanuelb opened this issue May 6, 2020 · 0 comments

Comments

@emanuelb
Copy link

emanuelb commented May 6, 2020

The repo contain pre-built binary gradle-wrapper.jar at:
android/gradle/wrapper/gradle-wrapper.jar
and related gradle-wrapper scripts at:
android/gradlew
android/gradlew.bat

As they inserted into the repo directly (as source) without package manager, a verification step is needed to ensure a malicious change wasn't introduced to them, see:

Verifying Gradle Wrappers with GitHub Actions
https://blog.gradle.org/gradle-wrapper-checksum-verification-github-action
https://docs.gradle.org/current/userguide/gradle_wrapper.html#wrapper_checksum_verification

To fix this issue, Gradle developed the "Gradle Wrapper Validation" Github action:
https://github.com/marketplace/actions/gradle-wrapper-validation

Which may add in the future verification for scripts as well, see open issue: "Validate gradlew scripts"
gradle/wrapper-validation-action#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant