Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config generation when minifying #2657

Merged
merged 2 commits into from Aug 17, 2021

Conversation

t3chguy
Copy link
Contributor

@t3chguy t3chguy commented Jul 9, 2021

Fixes #2656

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2657 (451c97f) into master (efde16b) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2657      +/-   ##
==========================================
- Coverage   95.18%   94.64%   -0.54%     
==========================================
  Files           5        5              
  Lines         166      168       +2     
==========================================
+ Hits          158      159       +1     
- Misses          8        9       +1     
Impacted Files Coverage Δ
lib/build.js 88.46% <100.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efde16b...451c97f. Read the comment docs.

@rejas rejas merged commit 313a7ad into Modernizr:master Aug 17, 2021
@rejas
Copy link
Member

rejas commented Aug 17, 2021

Thx for the PR, very much appreciated. Will pick it into the v3 branch and release a new version "soonish" (aka tomorrow if nothing goes wrong)

@rejas
Copy link
Member

rejas commented Aug 17, 2021

By the way: Do you feel adventourous enough to write a test for this so the code coverage goes up again?

rejas added a commit that referenced this pull request Aug 17, 2021
Co-authored-by: rejas <github@veeck.de>
@rejas
Copy link
Member

rejas commented Aug 17, 2021

Ok, "soonish" came quicker than I thought :-) Hope v3.11.8 helps your project a little!

@t3chguy
Copy link
Contributor Author

t3chguy commented Aug 17, 2021

Hah thanks, I ended manually mutating the minified output, and given we only rebuild modernizr every six months or so it'll come in handy for when I would have inevitably forgotten to mutate the minified output in another six months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minification breaks config during generation
2 participants