Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"options.state" isn't reflected to history.state #1857

Closed
tanagumo opened this issue May 24, 2017 · 1 comment · Fixed by #1889
Closed

"options.state" isn't reflected to history.state #1857

tanagumo opened this issue May 24, 2017 · 1 comment · Fixed by #1889
Labels
Type: Bug For bugs and any other unexpected breakage

Comments

@tanagumo
Copy link

Calling m.route.set with options.state within onmatch hook of a RouteResolver, options.state isn't reflected to history.state.

Is it a bug?
@pygy pygy added the Type: Bug For bugs and any other unexpected breakage label May 24, 2017
@pygy
Copy link
Member

pygy commented May 24, 2017

It is:

mithril.js/api/router.js

Line 42 in 7ee4e00

if (lastUpdate != null) options = {replace: true}
, thanks for the report

@tanagumo tanagumo changed the title "opitons.state" isn't reflected to history.state "options.state" isn't reflected to history.state May 24, 2017
pygy added a commit to pygy/mithril.js that referenced this issue Jul 5, 2017
@pygy
Don't overwrite the options object when redirecting from onmatch with…
a867754 
… m.route.set, fix MithrilJS#1857
@pygy pygy mentioned this issue Jul 5, 2017
Merged
@pygy pygy closed this as completed in #1889 Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't overwrite the options object when redirecting from onmatch with m.route.set pygy/mithril.js
2 participants
@pygy @tanagumo