Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"use strict" in global space of stream.js script #1831

Closed
spacejack opened this issue May 1, 2017 · 3 comments
Closed

"use strict" in global space of stream.js script #1831

spacejack opened this issue May 1, 2017 · 3 comments
Labels
Type: Bug For bugs and any other unexpected breakage
Projects

Comments

@spacejack
Copy link
Contributor

spacejack commented May 1, 2017

This: https://github.com/lhorie/mithril.js/blob/next/stream/stream.js#L1

Should probably be inside the IIFE?

Also appears in https://unpkg.com/mithril@1.1.1/stream/stream.js

Linting rules appear to prevent moving it: "Use the global form of 'use strict'"

One other thing, this is out of date: https://unpkg.com/mithril-stream

@dead-claudia
Copy link
Member

dead-claudia commented May 1, 2017

That would be a bug needing fixed.

Edit: re: global "use strict"

@dead-claudia dead-claudia added the Type: Bug For bugs and any other unexpected breakage label May 1, 2017
@dead-claudia
Copy link
Member

As for unpkg being out of date for that:

  1. mithril/stream is generally better to use, and is the one referenced in the docs.
  2. mithril-stream is out of date on npm.
  3. The docs for it are both inaccurate and inconsistent, and really should be fixed.

@dead-claudia dead-claudia added the Area: Documentation For anything dealing mainly with the documentation itself label May 1, 2017
@dead-claudia dead-claudia removed the Area: Documentation For anything dealing mainly with the documentation itself label Jun 15, 2017
pygy added a commit to pygy/mithril.js that referenced this issue Jul 11, 2017
pygy added a commit to pygy/mithril.js that referenced this issue Jul 11, 2017
pygy added a commit that referenced this issue Jul 11, 2017
@dead-claudia dead-claudia added this to Needs triage in Triage/bugs Oct 28, 2018
@dead-claudia
Copy link
Member

Triage/bugs automation moved this from Needs triage to Closed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug For bugs and any other unexpected breakage
Projects
Development

No branches or pull requests

2 participants