Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI/CD to GitHub Actions #117

Closed
danquack opened this issue Apr 25, 2023 · 4 comments
Closed

Switch CI/CD to GitHub Actions #117

danquack opened this issue Apr 25, 2023 · 4 comments

Comments

@danquack
Copy link
Contributor

To provide more visibility into build flows, it would be helpful to switch the build pipelines into actions.

@danquack
Copy link
Contributor Author

@gingerlime in #116 (comment), you suggested this. I opened this issue to start the conversation around it, before doing any work. I was curious, how would do you plan on authenticate to docker hub? Would you expose cred secrets within the repository? Would you switch to deploying to GitHub registry instead?

@danquack
Copy link
Contributor Author

danquack commented Apr 25, 2023

@gingerlime
Copy link
Contributor

gingerlime commented Apr 25, 2023

Thanks again @danquack. I'm not an expert on Github actions, but it (and also semaphore) allow defining secrets and using them, e.g. to authenticate to docker hub. That said, after the docker hub free organizations debacle, I'd be tempted to move to the Github registry anyway. I guess best to tackle one thing at a time though?

I'm slightly worried about how fast (or slow) Github actions might be. I think Semaphore provides faster instances, and it's taking some time even there. But build speed is not a huge concern anyway.

Are you okay starting on your own? if we can get something that builds the images and runs tests, that's a great start. I can then sort out secrets / pushing to the registry. Let me know if you have any questions!

EDIT: another challenge is whether we do this on master (thumbor 6.x) or on the 7.x branch. I'm still a bit unsure how to move forward with that one, since it needs more help.

@gingerlime
Copy link
Contributor

I think we can close this now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants