Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flamegraph_mode config option and query string parameter #508

Merged
merged 2 commits into from Aug 30, 2021
Merged

Add flamegraph_mode config option and query string parameter #508

merged 2 commits into from Aug 30, 2021

Conversation

evanleck
Copy link
Contributor

With this change, the :mode passed to StackProf.run can be customized just like the sample rate.

With this change, the :mode passed to StackProf.run can be customized
just like the sample rate.
@SamSaffron
Copy link
Member

This looks great to me, can you also add a note to the README here?

@OsamaSayegh can you double check?

@codecov-commenter
Copy link

Codecov Report

Merging #508 (43c0e9c) into master (3f47ae9) will decrease coverage by 0.26%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
- Coverage   87.51%   87.25%   -0.27%     
==========================================
  Files          18       18              
  Lines        1258     1263       +5     
==========================================
+ Hits         1101     1102       +1     
- Misses        157      161       +4     
Impacted Files Coverage Δ
lib/mini_profiler/profiler.rb 83.19% <0.00%> (-0.72%) ⬇️
lib/mini_profiler/config.rb 88.15% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f47ae9...43c0e9c. Read the comment docs.

Copy link
Collaborator

@OsamaSayegh OsamaSayegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just need a note about this in the README like Sam mentioned. Thank you for this!

@evanleck
Copy link
Contributor Author

@SamSaffron @OsamaSayegh my pleasure! I've added a note to the README as requested :)

@SamSaffron SamSaffron merged commit 3d3b430 into MiniProfiler:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants