Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old css #505

Merged
merged 4 commits into from Aug 2, 2021
Merged

Remove old css #505

merged 4 commits into from Aug 2, 2021

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Aug 2, 2021

This PR updates the CSS to remove these errors being flagged in Firefox:
Screenshot at Aug 02 10-14-30

I have tested this in the local demo app, I have also tested it in the https://github.com/o19s/quepid app by testing the branch:

gem 'rack-mini-profiler', git: 'https://github.com/epugh/rack-mini-profiler', branch: 'remove_old_css'

@epugh
Copy link
Contributor Author

epugh commented Aug 2, 2021

I just tested in Chrome, no warnings!

@SamSaffron
Copy link
Member

Looks good! thanks!

@SamSaffron SamSaffron merged commit 4e6d463 into MiniProfiler:master Aug 2, 2021
epugh added a commit to o19s/quepid that referenced this pull request Aug 6, 2021
* bump dev tool

* start pruning

* pending MiniProfiler/rack-mini-profiler#505 being merged and committed, this removes some warnings

* removing console warnings in FF about stylesheet issues

* remove alpha warnings

* we have fixes for miniprofiler

* needed for reference git repo as gem

* we should use sessions/new instead of /sessions when we create a new session!

* lint

* fix tests

* lint

* ignore resize, we dont seem to use it

* and remove it

* one more reference

* one more place we had index instead of new

* remove commented out code

* specify the path to favicon, avoiding console message about missing favicon

Co-authored-by: epugh@opensourceconnections.com <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants