Fix false 404 in logs when visiting /rack-mini-profiler/requests #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #243 (comment).
I tested the
/rack-mini-profiler/requests
on a brand new Rails app and I noticed anActionController::RoutingError
error printed to the console, but the page actually worked as expected (I got MP badge speed). The backtrace of the error pointed to this line:rack-mini-profiler/lib/mini_profiler/profiler.rb
Line 312 in 029854f
What is happening here is we are calling the next middlewares in the stack before we check for
path == '/rack-mini-profiler/requests'
which causes Rails to print that error because it doesn't recognize our route (rightfully so). The fix is to simply do our check before we call the next middleware in the chain.