Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix client timings regression and bring back 'show trivial' #441

Merged
merged 1 commit into from May 25, 2020
Merged

FIX: Fix client timings regression and bring back 'show trivial' #441

merged 1 commit into from May 25, 2020

Conversation

OsamaSayegh
Copy link
Collaborator

Fix for #440

Client timings regressed when we removed jQuery a while ago; this PR fixes the regression. Tested on IE11 to ensure MP doesn't regress on IE11.

image

@codecov-commenter
Copy link

Codecov Report

Merging #441 into master will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
- Coverage   88.48%   88.38%   -0.10%     
==========================================
  Files          22       22              
  Lines        1337     1317      -20     
==========================================
- Hits         1183     1164      -19     
+ Misses        154      153       -1     
Impacted Files Coverage Δ
lib/mini_profiler/asset_version.rb 100.00% <100.00%> (ø)
lib/mini_profiler/timer_struct/page.rb 88.88% <0.00%> (-1.12%) ⬇️
lib/mini_profiler/timer_struct/sql.rb 84.21% <0.00%> (-0.79%) ⬇️
lib/mini_profiler/gc_profiler.rb 96.25% <0.00%> (-0.18%) ⬇️
lib/mini_profiler/client_settings.rb 94.11% <0.00%> (-0.09%) ⬇️
lib/mini_profiler/storage/redis_store.rb 95.58% <0.00%> (-0.07%) ⬇️
lib/mini_profiler/timer_struct/request.rb 98.98% <0.00%> (-0.02%) ⬇️
lib/mini_profiler/timer_struct/client.rb 100.00% <0.00%> (ø)
lib/mini_profiler/timer_struct/custom.rb 100.00% <0.00%> (ø)
lib/mini_profiler_rails/railtie_methods.rb 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7026ca7...1497696. Read the comment docs.

@SamSaffron
Copy link
Member

cool I will do a new release!!

@OsamaSayegh OsamaSayegh deleted the fix-client-timings branch May 25, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants