Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link to the pages.navigateToApp() documentation on this page is broken #10894

Open
AE-MS opened this issue May 17, 2024 · 8 comments · Fixed by #10972 · May be fixed by #11006
Open

The link to the pages.navigateToApp() documentation on this page is broken #10894

AE-MS opened this issue May 17, 2024 · 8 comments · Fixed by #10972 · May be fixed by #11006
Assignees
Labels
doc-bug Out of date, unclear, confusing, typo, or broken - including missing information. needs-triage 🔍 teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label

Comments

@AE-MS
Copy link

AE-MS commented May 17, 2024

Type of issue

Feature doesn't work (bug)

Feedback

In this section:
https://learn.microsoft.com/en-us/microsoftteams/platform/concepts/build-and-test/deep-link-application?tabs=teamsjs-v2#configure-deep-link-to-a-tab-using-teamsjs
...there is this text:
"For more information about using the pages capability, see pages.navigateToApp() and the pages namespace..."

The pages.navigateToApp() link goes here:
https://learn.microsoft.com/en-us/javascript/api/@microsoft/teams-js/pages?view=msteams-client-js-latest#@microsoft-teams-js-pages-navigatetoapp&preserve-view=true

That does not actually direct you to the documentation for that function. Instead, it only takes you to the top of the page. The working link is:
https://learn.microsoft.com/en-us/javascript/api/@microsoft/teams-js/pages?view=msteams-client-js-latest#@microsoft-teams-js-pages-navigatetoapp

That's a very similar URL, but it does not have the &preserve-view=true part tacked on to the end. That part seems to be what is breaking the direct navigation.

Page URL

https://learn.microsoft.com/en-us/microsoftteams/platform/concepts/build-and-test/deep-link-application?tabs=teamsjs-v2#configure-deep-link-to-browse-within-your-app-manually

Content source URL

https://github.com/MicrosoftDocs/msteams-docs/blob/main/msteams-platform/concepts/build-and-test/deep-link-application.md

Author

@v-npaladugu

Document Id

059b1a94-8235-8801-b9e0-ac6fbc485a7c

Copy link
Contributor

Hi AE-MS! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

@AE-MS
Copy link
Author

AE-MS commented May 17, 2024

This same problem seems to exist with many of the direct-to-function link attempts on that page. Did the docs navigation system used to support &preserve-view=true and now it doesn't?

@ChetanSharma-msft ChetanSharma-msft added the teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label label May 20, 2024
@ChetanSharma-msft
Copy link
Collaborator

Hello @AE-MS - Thanks for raising your query.
We will look into it and let you know the updates.

@Vaibhav-MSFT
Copy link

Hello @surbhigupta12 ,
Can you please help here in updating the document as suggested. We also found that the navigation is broken and does not point to the exact section for pages.navigateToApp().

@Prasad-MSFT Prasad-MSFT added doc-bug Out of date, unclear, confusing, typo, or broken - including missing information. and removed needs-triage 🔍 labels May 28, 2024
@v-ramyas5 v-ramyas5 linked a pull request May 29, 2024 that will close this issue
Copy link
Contributor

Tell us about your experience!

Hi AE-MS! This issue is closed in our system. We would like your feedback on your experience with our support team and Platform.

Best regards,
Teams Platform

@AE-MS
Copy link
Author

AE-MS commented Jun 6, 2024

@v-ramyas5 @surbhigupta12
This issue is not completely fixed. In my comment above, I said:

"This same problem seems to exist with many of the direct-to-function link attempts on that page."

However, the fix to which you linked only fixed the problem for the specific pages.navigateToApp() link. There are many other deep links on the page that are still broken. If this issue is not tracking fixing the whole page, which issue is?

Copy link
Contributor

Hi AE-MS! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

@surbhigupta12
Copy link
Collaborator

@AE-MS, apologies for the oversight. We have reopened the issue and are working on resolving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-bug Out of date, unclear, confusing, typo, or broken - including missing information. needs-triage 🔍 teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label
Projects
None yet
7 participants