Skip to content

Remove error props #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Remove error props #110

merged 3 commits into from
Jun 15, 2022

Conversation

lramos15
Copy link
Member

Error props used to be a compliance issue but no longer seem needed and cause lots of confusion. This PR removes them in one of our very few breaking changes to the .d.ts so people are aware of this.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lramos15 Logan Ramos
@lramos15 lramos15 requested a review from sbatten June 13, 2022 14:57
@lramos15 lramos15 self-assigned this Jun 13, 2022
sbatten
sbatten previously approved these changes Jun 13, 2022
Copy link
Member

@sbatten sbatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, awaiting review for team

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lramos15 Logan Ramos

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lramos15 Logan Ramos
@lramos15 lramos15 merged commit c77fda6 into main Jun 15, 2022
@lramos15 lramos15 deleted the lramos15/reluctant-shark branch June 15, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants