Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have publish --help show valid arguments for --target #763

Closed
wandyezj opened this issue Aug 12, 2022 · 1 comment · Fixed by #766
Closed

have publish --help show valid arguments for --target #763

wandyezj opened this issue Aug 12, 2022 · 1 comment · Fixed by #766
Assignees
@joaomoreno
Labels
released

Comments

@wandyezj
Copy link
Contributor

Currently publish --help does not show valid target architectures.

-t, --target <targets...> Target architectures

It's unclear what architectures are valid. It would be good to specify what architectures are allowed as a part of the target description.

Running with an invalid architecture gives an error with a list of valid architectures:

ERROR 'test' is not a valid VS Code target. Valid targets: win32-x64, win32-ia32, win32-arm64, linux-x64, linux-arm64, linux-armhf, darwin-x64, darwin-arm64, alpine-x64, alpine-arm64, web

Since the valid architectures are known it would be great if these could be shown as part of parameter help description.
@wandyezj wandyezj changed the title have publish --help show valid targets for --target have publish --help show valid arguments for --target Aug 12, 2022
@joaomoreno joaomoreno assigned joaomoreno and unassigned sandy081 Aug 19, 2022
joaomoreno added a commit that referenced this issue Aug 19, 2022
@joaomoreno
fix: list all valid targets in documentation for --target
91a0775 
Fixes: #763
@joaomoreno joaomoreno mentioned this issue Aug 19, 2022
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 2.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

joaomoreno added a commit that referenced this issue Aug 19, 2022
@joaomoreno
fix: list all valid targets in documentation for --target (#766)
0940626 
Fixes: #763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: list all valid targets in documentation for --target microsoft/vscode-vsce
3 participants
@joaomoreno @wandyezj @sandy081