Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line flag to not update source package.json version #596

Closed
JustinGrote opened this issue Aug 21, 2021 · 6 comments
Closed

Add command line flag to not update source package.json version #596

JustinGrote opened this issue Aug 21, 2021 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality released
Milestone

Comments

@JustinGrote
Copy link

JustinGrote commented Aug 21, 2021

I do my builds in CI so my source package.json version is always "0.0.0-source". However when running vsce package locally for testing it updates the version, and I occassionally accidentally commit this version because of it. Provide a command line parameter similar to --no-git-tag-version e.g. --no-packagejson-version

Workarounds

  1. Local selective gitignore on the package.json, not great
  2. Only do builds in CI and don't push git changes
@joaomoreno
Copy link
Member

vsce package should not update the version automatically. Do you find that it does? Can you show me? Do you have steps?

@joaomoreno joaomoreno self-assigned this Aug 31, 2021
@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Aug 31, 2021
@JustinGrote
Copy link
Author

@joaomoreno to be clear this is when specifying a version at the command line, e.g. vsce package --no-git-tag-version v1.2.3
image
image

@joaomoreno joaomoreno added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Sep 10, 2021
@zimmski
Copy link

zimmski commented Sep 12, 2021

Can confirm that this is with the version added to "package". Just had the same problem.

@joaomoreno
Copy link
Member

Will add --no-update-package-json.

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

🎉 This issue has been resolved in version 1.102.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JustinGrote
Copy link
Author

@joaomoreno thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality released
Projects
None yet
Development

No branches or pull requests

3 participants