--noGitHubIssueLinking option doesn't work properly

[horihiro]

According to the following code, this.expandGitHubIssueLinks is set to true when the option is not only specified but also not specified.

vscode-vsce/src/main.ts

Line 104 in f186af2

expandGitHubIssueLinks: noGitHubIssueLinking,

vscode-vsce/src/package.ts

Lines 441 to 442 in f186af2

	this.expandGitHubIssueLinks =
	typeof options.expandGitHubIssueLinks === 'boolean' ? options.expandGitHubIssueLinks : true;

So GitHub issue links in Markdown files are always expanded regardless of the option.

[horihiro]

The test for expandGitHubIssueLinks option of ReadmeProcessor exists, this test abehavior when expandGitHubIssueLinks is false as the following.

vscode-vsce/src/test/package.test.ts

Line 2002 in f186af2

const processor = new ReadmeProcessor(manifest, { expandGitHubIssueLinks: false });

But as I commented, expandGitHubIssueLinks is always true as above.

[horihiro]

Hi @joaomoreno , Could you please look into this? Thanks.