Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json repository url not read #527

Closed
LuisPeregrinaIBM2 opened this issue Jan 19, 2021 · 3 comments
Closed

package.json repository url not read #527

LuisPeregrinaIBM2 opened this issue Jan 19, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@LuisPeregrinaIBM2
Copy link

When creating VSIX and using a relative image in the README.md it says:
ERROR Couldn't detect the repository where this extension is published. The image 'preview.png' will be broken in README.md. Please provide the repository URL in package.json or use the --baseContentUrl and --baseImagesUrl options.

However, there is a repo url in package.json:

{
	...
	"repository": {
		"type": "git",
		"url": "https://***.git"
	},
@joaomoreno
Copy link
Member

joaomoreno commented Jan 19, 2021

Is it a github repo? Is it a public repo?

@LuisPeregrinaIBM2
Copy link
Author

github enterprise, public repo

@LuisPeregrinaIBM2
Copy link
Author

either way, parameter baseImagesUrl works, so either the message is missing some additional info (github.com repos only) or it's not parsed correctly.

@joaomoreno joaomoreno self-assigned this Jan 21, 2021
@joaomoreno joaomoreno added this to the January 2021 milestone Jan 21, 2021
joaomoreno added a commit that referenced this issue Jan 21, 2021
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants