Update tslib to support new __spreadArray helper #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orta, CI for 14.x failed but I'm not sure why: https://github.com/microsoft/tslib/pull/133/checks?check_run_id=1393759257#step:4:35 |
ExE-Boss
reviewed
Nov 13, 2020
| export declare function __spreadArrays(...args: any[][]): any[]; | ||
| export declare function __spreadArray(to: any[], from: any[]): any[]; |
There was a problem hiding this comment.
This is more correct:
Suggested change
| export declare function __spreadArray(to: any[], from: any[]): any[]; | |
| export declare function __spreadArray<T, U>(to: T[], from: ReadonlyArray<U>): Array<T | U>; |
Although this would be even more correct, it depends on TypeScript 4.0:
export declare function __spreadArray<T extends any[], U extends readonly any[]>(to: T, from: U): [...T, ...U];There was a problem hiding this comment.
The types here are fairly simplistic. If we were going to add generics here we would want to add them to other functions as well, but that's out of scope for now.
|
Do note that |
|
Thanks! Got a local repro for the fail |
|
Great catch on the |
orta
approved these changes
Nov 18, 2020
|
@DanielRosenwasser this will probably need to be published before we merge microsoft/TypeScript#41523 so anyone using our nightlies can get a working copy of tslib. |
|
Which version of TypeScript will start using |
|
@Finesse TypeScript is using |
Gusted
added a commit
to darkreader/darkreader
that referenced
this pull request
Mar 7, 2021
- Since Typescript 4.2 some Helpers to transpile to 4.2 are deprecated/removed. This includes __spread and __spreadArrays microsoft/TypeScript#41523. - We heavily use the spread syntax in Dark Reader and thus need those helper functions. - Due the upgrade of 4.2, tslib was outdated and didn't had the new helper function `__spreadArray`. - After good hours of skimming trough the compiler and using the wrong commands to update tslib(default to 1.x). manually updating it to 2.1 which includes this new functions microsoft/tslib#133 https://github.com/microsoft/tslib/releases/tag/2.1.0 the API can be properly compiled again. - Resolves #My personal issues with the API.
Gusted
added a commit
to darkreader/darkreader
that referenced
this pull request
Mar 7, 2021
- Since Typescript 4.2 some Helpers to transpile to 4.2 are deprecated/removed. This includes __spread and __spreadArrays microsoft/TypeScript#41523. - We heavily use the spread syntax in Dark Reader and thus need those helper functions. - Due the upgrade of 4.2, tslib was outdated and didn't had the new helper function `__spreadArray`. - After good hours of skimming trough the compiler and using the wrong commands to update tslib(default to 1.x). manually updating it to 2.1 which includes this new functions microsoft/tslib#133 https://github.com/microsoft/tslib/releases/tag/2.1.0 the API can be properly compiled again. - Resolves #My personal issues with the API. Note to myself: Now their are 2 versions installed `2.1.10` and `1.14.1` properly configuration setups should default to 2.1.10. But for sakes if I get into problems with this I hope I remember this note and don't waste some hours. Why `1.14.1`, I don't know. `npm --save-dev -E tslib` defaults to 1.14.1. It seems like an NPM bug `yarn add --dev -E tslib` gives the correct 2.1.10. Damn dependency hell =).
This was referenced Mar 15, 2021
Closed
This was referenced Jun 6, 2021
1 task
This was referenced Jun 11, 2021
This was referenced Jun 30, 2021
1 task
1 task
efokschaner
added a commit
to efokschaner/algorithm
that referenced
this pull request
Jul 12, 2021
The version + features of typescript used to compile this lib means that tslib needs to be at version 2.0.0 minimum. Because `antvis/algorithm` doesn't specify an explicit version, it is not guaranteed that developers receive the necessary version. This causes the following error at import time: ``` ./node_modules/@antv/algorithm/es/gaddi.js Attempted import error: '__spreadArray' is not exported from 'tslib'. ``` You can see here all the other projects updating their tslib dependencies similarly in the references to this PR: microsoft/tslib#133 This relates to antvis/G6#2702 and antvis/G6#2713 it is likely necessary, but may not be sufficient, to fix those reported issues. There could be other `antvis` packages with the same issue.
1 task
This was referenced Jul 24, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the same change from microsoft/TypeScript#41523. This also deprecates
__spreadand__spreadArrays, as they have been subsumed by__spreadArray. If we want to remove__spreadand__spreadArrays, that would require a major version bump.