Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electron): fix the directory app path #19601

Merged
merged 1 commit into from Dec 20, 2022
Merged

fix(electron): fix the directory app path #19601

merged 1 commit into from Dec 20, 2022

Conversation

pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Dec 20, 2022 •
edited

Fixes: #19540

dgozman
dgozman approved these changes Dec 20, 2022
View reviewed changes
tests/electron/electron-app.spec.ts
const closePromise = new Promise(f => electronApp.process().on('close', f));
await electronApp.evaluate(({ app }) => {
app.quit();
});
await closePromise;
});

test('should run pre-ready apis', async ({ launchElectronApp }) => {
await launchElectronApp('electron-pre-ready-app.js');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing this file from the PR?

tests/electron/electron-app.spec.ts
});

test('should resolve app path for folder apps', async ({ launchElectronApp }) => {
const electronApp = await launchElectronApp('.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

@pavelfeldman pavelfeldman merged commit 95cc5c2 into microsoft:main Dec 20, 2022
pavelfeldman added a commit that referenced this pull request Dec 20, 2022
@pavelfeldman
cherry-pick(#19601): fix(electron): fix the directory app path
0237b7b
@ARUMAIS ARUMAIS mentioned this pull request Jan 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pavelfeldman @dgozman