chore: make local docker build work on branch #17896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch does not pass `isDevelopmentBuild` check because it does not have a version ending with `-next`. Therefore, `env.PWTEST_DOCKER_BASE_IMAGE` is ignored which leads to the pull of non-existent image.
yury-s
approved these changes
Oct 7, 2022
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Oct 7, 2022
…branch Branch does not pass `isDevelopmentMode` check because it does not have a version ending with `-next`. Therefore, `env.PWTEST_DOCKER_BASE_IMAGE` is ignored which leads to the pull of non-existent image.
dgozman
added a commit
that referenced
this pull request
Oct 7, 2022
…17906) Branch does not pass `isDevelopmentMode` check because it does not have a version ending with `-next`. Therefore, `env.PWTEST_DOCKER_BASE_IMAGE` is ignored which leads to the pull of non-existent image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch does not pass
isDevelopmentModecheck because it does not have a version ending with-next. Therefore,env.PWTEST_DOCKER_BASE_IMAGEis ignored which leads to the pull of non-existent image.