feat: introduce docker integration #16382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aslushnikov When we add docs, make sure we tell people to increase default CPU and mem limit on their docker install (https://playwright.slack.com/archives/C01AG7QGW2F/p1659463173880389?thread_ts=1659428827.669649&cid=C01AG7QGW2F) otherwise they'll likely hit unexpected perf issues if they have a freshly installed Docker-for-Desktop. |
aslushnikov
force-pushed
the
introduce-docker-integration
branch
from
5df033d
to
8a9cb3d
Compare
mxschmitt
force-pushed
the
main
branch
2 times, most recently
from
34dd80c
to
5578b86
Compare
mxschmitt
reviewed
Aug 15, 2022
mxschmitt
reviewed
Aug 15, 2022
|
Can you add user docs (either directly here or in another PR) and then I'll review both docs and impl in one? |
aslushnikov
force-pushed
the
introduce-docker-integration
branch
2 times, most recently
from
c25c957
to
0a3e7ca
Compare
aslushnikov
force-pushed
the
introduce-docker-integration
branch
from
3b06d19
to
add84ca
Compare
mxschmitt
reviewed
Sep 6, 2022
mxschmitt
reviewed
Sep 6, 2022
mxschmitt
reviewed
Sep 6, 2022
mxschmitt
reviewed
Sep 6, 2022
mxschmitt
reviewed
Sep 7, 2022
mxschmitt
reviewed
Sep 7, 2022
This patch introduces the following commands: - `npx playwright docker build` that builds a VRT docker image locally that is based off the `mcr.microsoft.com/playwright:jammy` - `npx playwright docker start` that launches a docker container with browsers. - `npx playwright docker stop` that stops given docker container. - `npx playwright docker test` that runs all the tests inside a launched docker container.
aslushnikov
force-pushed
the
introduce-docker-integration
branch
from
ce77898
to
c910a9b
Compare
mxschmitt
force-pushed
the
introduce-docker-integration
branch
from
55e96f2
to
7f20c79
Compare
dgozman
reviewed
Sep 8, 2022
|
Note for self: also add docker desktop recommended settings that @rwoll recommended |
mxschmitt
approved these changes
Sep 9, 2022
dgozman
approved these changes
Sep 9, 2022
mxschmitt
reviewed
Sep 9, 2022
| }); | ||
| }); | ||
|
|
||
| test('make sure it tells to run `npx playwright docker build` when image is not instaleld', async ({ exec }) => { |
There was a problem hiding this comment.
Suggested change
| test('make sure it tells to run `npx playwright docker build` when image is not instaleld', async ({ exec }) => { | |
| test('make sure it tells to run `npx playwright docker build` when image is not installed', async ({ exec }) => { |
aslushnikov
added a commit
that referenced
this pull request
Sep 19, 2022
This reverts commit af042be.
This was referenced Oct 18, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 25, 2022
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the following commands:
npx playwright install docker-imagethat builds a VRT docker imagelocally that is based off the
mcr.microsoft.com/playwright:focalnpx playwright start-dockerthat launches a docker container withbrowsers.
npx playwright stop-dockerthat stops given docker container.npx playwright test --dockerthat runs all the tests inside alaunched docker container.