fix(esm loader): support Node 18.6 #15694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small change in the API requires `shortCircuit: true` when returning the transformed source. Another API change removes third argument from the chained resolve/load, but passing three instead of two still works.
pavelfeldman
approved these changes
Jul 15, 2022
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jul 15, 2022
A small change in the API requires `shortCircuit: true` when returning the transformed source. Another API change removes third argument from the chained resolve/load, but passing three instead of two still works.
rwoll
pushed a commit
to rwoll/playwright
that referenced
this pull request
Jul 15, 2022
A small change in the API requires `shortCircuit: true` when returning the transformed source. Another API change removes third argument from the chained resolve/load, but passing three instead of two still works.
rwoll
pushed a commit
to rwoll/playwright
that referenced
this pull request
Jul 15, 2022
A small change in the API requires `shortCircuit: true` when returning the transformed source. Another API change removes third argument from the chained resolve/load, but passing three instead of two still works.
dgozman
added a commit
that referenced
this pull request
Jul 15, 2022
A small change in the API requires `shortCircuit: true` when returning the transformed source. Another API change removes third argument from the chained resolve/load, but passing three instead of two still works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change in the API requires
shortCircuit: truewhen returning the transformed source.Another API change removes third argument from the chained resolve/load, but passing three instead of two still works.