Revert "feat(matchers): add toContainClass (#15491)" #15670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e4debd0.
dgozman
approved these changes
Jul 14, 2022
mxschmitt
added a commit
to mxschmitt/playwright
that referenced
this pull request
Jul 14, 2022
…ass (microsoft#15491)" This reverts commit e4debd0.
rwoll
pushed a commit
to rwoll/playwright
that referenced
this pull request
Jul 15, 2022
…ass (microsoft#15491)" This reverts commit e4debd0.
rwoll
pushed a commit
to rwoll/playwright
that referenced
this pull request
Jul 15, 2022
…ass (microsoft#15491)" This reverts commit e4debd0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e4debd0.
Motivation: It's confusing between passing an array and not an array or a nested array. This in combination with having two methods (toHaveClass) and the ability to match multiple elements / locators is not idiomatic so we'll hold it back for now until the API is more clearer.
Reopens #14117.