Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: roll to Playwright 1.26.0-beta-1663620933000 #1555

Merged
merged 4 commits into from Sep 20, 2022

Conversation

rwoll
Copy link
Member

@rwoll rwoll commented Sep 19, 2022

Ports:

@@ -458,22 +458,26 @@ async def not_to_be_disabled(

async def to_be_editable(
self,
editable: bool = None,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idiomatically, this should be:

Suggested change
editable: bool = None,
editable: bool = True,

but the our generation/rolling will yell with:

Parameter type mismatch in LocatorAssertions.to_be_enabled(enabled=): documented as Union[bool, None], code has bool

Unless others feel strongly, this will be left as is. (Slightly non-idiomatic Python.)

@rwoll rwoll merged commit 7091748 into microsoft:main Sep 20, 2022
@rwoll rwoll deleted the roll/1.26-recut branch September 20, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants