Use None instead of NoneType for API type annotations #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Seems the CLA bot did not work, could you try sign the CLA here? |
|
@jcheng5 Can you sign the CLA or let us know if you already have? Looks like the bot is reporting it as not signed. We will be releasing 1.26 soon, so would love to include this! Thanks! |
|
So sorry, this is awkward, but I sent the CLA off to legal 11 days ago or whatever... and used the wrong email address 🤦♂️ I hopefully will be able to get their signoff in the next day or two. |
|
Sweet! Just drop a comment here once you get it back, and I will follow up with the land. Cheers! |
|
OK sorry for the delay--I just signed the CLA. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1532