Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Route.abort not report handled #1458

Merged
merged 1 commit into from
Jul 27, 2022
Merged

fix Route.abort not report handled #1458

merged 1 commit into from
Jul 27, 2022
+2 −0

Conversation

x0day
Copy link
Contributor

@x0day x0day commented Jul 27, 2022

this PR fixes #1457, #1402

@x0day
fixes microsoft#1457

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5b6c671
@mxschmitt mxschmitt requested a review from rwoll July 27, 2022 14:14
@rwoll rwoll merged commit 5f95476 into microsoft:main Jul 27, 2022
@rwoll
Copy link
Member

rwoll commented Jul 27, 2022

@x0day Thanks for the contribution. Looks like this was missed in the port.

@x0day x0day deleted the patch-1 branch July 28, 2022 00:08
@mxschmitt mxschmitt mentioned this pull request Jul 30, 2022
Closed
rwoll pushed a commit to rwoll/playwright-python that referenced this pull request Aug 1, 2022
@x0day @rwoll
cherry-pick(microsoft#1458): fix: route.abort failed missing handle r…
fc46d63 
…eport

Fixes microsoft#1457.
rwoll added a commit that referenced this pull request Aug 1, 2022
@rwoll
cherry-pick(#1458): fix: route.abort failed missing handle report (#1472

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5c2500e 
)
@FatMauld
Copy link

Is this still an issue? I'm using 1.27.1.
If I add this to my code:
page.route(re.compile(r"(\.png$)|(\.jpg$)"), lambda route: route.abort())

I've verified images don't load which is desired but when the script finishes, I get a bunch of these:

Task was destroyed but it is pending!
task: <Task pending name='Task-666' coro=<Page._on_route() running at /home/username/.local/lib/python3.8/site-packages/playwright/_impl/_page.py:251> wait_for=<_GatheringFuture finished exception=CancelledError()>>
_GatheringFuture exception was never retrieved
future: <_GatheringFuture finished exception=CancelledError()>
asyncio.exceptions.CancelledError

@erma0 erma0 mentioned this pull request Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwoll rwoll

@mxschmitt mxschmitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Task was destroyed but it is pending! in route.abort()
4 participants
@x0day @rwoll @FatMauld @mxschmitt