Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tasks): cancel all the pending tasks as we exit own loop #1430

Merged
merged 1 commit into from Jul 13, 2022
Merged

fix(tasks): cancel all the pending tasks as we exit own loop #1430

merged 1 commit into from Jul 13, 2022

Conversation

pavelfeldman
Copy link
Member

Fixes #1402

@rwoll rwoll merged commit 1c69b53 into microsoft:main Jul 13, 2022
@rwoll
Copy link
Member

rwoll commented Jul 13, 2022

Thanks! I'll follow up with a test addition.

rwoll pushed a commit to rwoll/playwright-python that referenced this pull request Jul 13, 2022
@pavelfeldman @rwoll
fix(tasks): cancel all the pending tasks as we exit own loop (microso…
c382fd8 
…ft#1430)
rwoll added a commit that referenced this pull request Jul 13, 2022
@rwoll
cherry-pick(#1430): fix(tasks): cancel all the pending tasks as we ex…
162afd7 
…it own loop (#1431)

fix(tasks): cancel all the pending tasks as we exit own loop (#1430)
@ja8zyjits ja8zyjits mentioned this pull request Jul 18, 2022
Closed
@mxschmitt mxschmitt mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question]: Task was destroyed but it is pending! in route.abort()
3 participants
@pavelfeldman @rwoll @dgozman