Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

GraphQL language support #54

Merged
merged 7 commits into from
Jan 9, 2019
Merged

GraphQL language support #54

merged 7 commits into from
Jan 9, 2019

Conversation

langpavel
Copy link
Contributor

@langpavel langpavel commented Nov 21, 2018

Add GraphQL coloring and delegates block strings (mostly used for descriptions) to markdown

@msftclas
Copy link

msftclas commented Nov 21, 2018

CLA assistant check
All CLA requirements met.

@alexdima alexdima changed the title GraphQL language support [WIP] GraphQL language support Nov 23, 2018
@langpavel
Copy link
Contributor Author

Hi @alexandrudima can you help me? If you can look and give me some clue, or if you can ask community for help..

I'm also curious if full language service for GraphQL can be easily implemented instead of this PR 🤔

I really wish Monaco editor as default in GraphiQL soon 🙂

@alexdima
Copy link
Member

alexdima commented Dec 7, 2018

@langpavel I think starting small and slowly improving is definitely the right way to go about this! I am happy to help with specific technical questions, but I am sorry I don't have the necessary time to learn the GraphQL syntax and then help with the syntax highlighter per se.

But I can help with examples or specific questions.

Also, if you get only basic coloring working, I am happy to merge that in. We can always refine it later on, IMHO it doesn't need to be perfect to ship. I also don't really have a magic wand to gather contributors for this colorizer. The best is for your to bring it in some shippable state, then I can merge it, and then hopefully people start using it and then will want to come and improve it with other PRs.

@langpavel
Copy link
Contributor Author

Hi @alexandrudima

I think that basic coloring working is there and it can be shipped. As you said, we can always refine it later :-)

@langpavel
Copy link
Contributor Author

langpavel commented Dec 8, 2018

I'm adding nested MarkDown support for block strings
See GraphQL Specification # Descriptions why

@langpavel
Copy link
Contributor Author

Now I'm super excited 🍾
graphql-preview

@langpavel langpavel changed the title [WIP] GraphQL language support GraphQL language support Dec 8, 2018
@langpavel
Copy link
Contributor Author

langpavel commented Dec 8, 2018

I have a question @alexandrudima:
Can I mark entire nested language block with CSS class? The goal should be different (background/base) color for embedded language

@alexdima
Copy link
Member

alexdima commented Jan 9, 2019

Unfortunately not, the background cannot be controlled from the tokens+themes at this time.

@alexdima
Copy link
Member

alexdima commented Jan 9, 2019

Thank you!

@alexdima alexdima merged commit 03a8259 into microsoft:master Jan 9, 2019
@alexdima alexdima added this to the February 2019 milestone Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants