Fix JavaScript RegExp range closing bracket #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdima
added a commit
to microsoft/monaco-languages
that referenced
this pull request
Mar 1, 2019
|
👍 Thank you! |
|
@alexandrudima Happy to help! My change was just for the editable example. I couldn't find where the actual JavaScript Monarch language file is. It seems to have the same issue. Is it in a private repo? |
|
@jbsulli I've applied your change also to the |
|
Awesome! Thank you so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Monarch tokenizer for JavaScript has a bug where the closing bracket for the RegExp range refers to a
bracketsattribute that does not exist. This bug causes the closing bracket to not be colored using the regexp style.