Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ES6-Compliant Distribution #60

Closed
fedoranimus opened this issue Jul 12, 2016 · 12 comments
Closed

Create ES6-Compliant Distribution #60

fedoranimus opened this issue Jul 12, 2016 · 12 comments
Labels
feature-request Request for new features or functionality integration
Milestone

Comments

@fedoranimus
Copy link

fedoranimus commented Jul 12, 2016

While AMD is useful, it can be a pain to use in modern web applications, especially those using Typescript.

It would be excellent for this project to support an ES6 Distribution so that the following syntax (or similar) can be used:
import * as monaco from 'monaco-editor'

This would greatly ease the difficulty of implementing this tool moving forward and also help it stay standards-compliant.

Edit: Grammar

@alexdima alexdima added feature-request Request for new features or functionality integration labels Aug 15, 2016
@marxo
Copy link

marxo commented Aug 18, 2016

This would be preferable to existing solutions. We're using Meteor and using AMD modules results in conflict with other modules sometimes. Can @alexandrudima or someone else from the team explain why this would be difficult to integrate as labeled?

@alexdima
Copy link
Member

Sorry, I struggled with the label name.

I tried to classify issues that concern how easy/difficult it is for the editor to be consumed/integrated.

@0x-r4bbit
Copy link

Can we expect an update on this soon? Unfortunately, I'm not very familiar with module loading approaches, so I won't be a great help here when it comes to contributions... however, since this issue is a couple of months old, I'm wondering if there's any progress here.

Otherwise I'll see if there are other alternatives. But I think too that for Monaco's adoption, getting rid off AMD dependency is a good idea.

@DinkDonk
Copy link

This should absolutely get top priority. Would love to be able to - sanely - use monaco in a TypeScript environment.

@jarben
Copy link

jarben commented Sep 28, 2017

Any updates on this?

@jurajhrib
Copy link

+1

4 similar comments
@jiron12
Copy link

jiron12 commented Nov 7, 2017

+1

@devmondo
Copy link

devmondo commented Nov 7, 2017

+1

@nadavwix
Copy link

+1

@vudzero
Copy link

vudzero commented Dec 30, 2017

+1

@zikaari
Copy link

zikaari commented Dec 30, 2017

I think the one of the main reasons monaco is AMD based is probably because how it handles Workers. monaco internally uses require.toUrl to resolve paths to worker files. It'd huge progress towards this goal if monaco "outsources" this mechanism instead of doing it by itself.

@alexdima
Copy link
Member

Done with #18

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality integration
Projects
None yet
Development

No branches or pull requests