Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLHint (or extension support) #34

Closed
ptyork opened this issue Jun 27, 2016 · 16 comments
Closed

HTMLHint (or extension support) #34

ptyork opened this issue Jun 27, 2016 · 16 comments
Labels
feature-request Request for new features or functionality html out-of-scope
Milestone

Comments

@ptyork
Copy link

ptyork commented Jun 27, 2016

Currently VSCode/Monaco supports linting for a good number of languages, but HTML is not one of them. VSCode makes up for this with an extension: https://github.com/Microsoft/vscode-htmlhint

So, will VSCode extensions (perhaps with minor mods) work in Monaco? If not, any plans to add HTML linting?

@alexdima
Copy link
Member

fyi @aeschli

Today the html language support is still inside monaco-editor-core aka in the vscode repo. That is because 100% the same code ships with vscode and with the editor. We plan to break up this code, to create a vscode html extension and once that is done, we can create a monaco-html editor plugin that reuses some of the code, but that is independent of vscode. We can then consider adding more features to it.

TL;DR we can't do it yet due to it affecting vscode, but we plan to fix this by making things separate.

@alexdima alexdima added the feature-request Request for new features or functionality label Jun 28, 2016
@ptyork
Copy link
Author

ptyork commented Jun 28, 2016

Sounds good, thanks. I'm creating a tool to help students learn HTML+CSS so this will be quite helpful. Happy to help with this when it becomes possible.

@joeskeen
Copy link

@alexandrudima would the creation of a monaco-html editor plugin include support for Emmet?

@alexdima alexdima added this to the Backlog milestone Aug 31, 2016
@scniro
Copy link

scniro commented Apr 27, 2017

@alexandrudima has there been any positive progress on this? I as well am trying to indicate syntax errors while editing HTML

@scniro
Copy link

scniro commented Apr 27, 2017

May I add that I see the monaco-html plugin. @alexandrudima is there I way I can accomplish the hinting with this module? I'm browsing the object and monaco.languages.html.htmlDefaults appears to be missing diagnosticsOptions similar to the other languages. Am I overlooking something?

@aeschli
Copy link
Contributor

aeschli commented Apr 27, 2017

The Monaco HTML support doesn't include any validation and there are currently no plans to work on it. Contributions are welcome. The code base is at https://github.com/Microsoft/vscode-html-languageservice.

@scniro
Copy link

scniro commented Apr 27, 2017

@aeschli may I ask, why? Is validating HTML just outright not interesting to Microsoft, or is it just backlogged pretty deep? I open up VS Code and have no sense of assurance that any of my markup is even close to being valid. I find this very surprising.

@aeschli
Copy link
Contributor

aeschli commented Apr 27, 2017

It just hasn't gotten any priority yet and surprisingly there haven't been many requests for it. My guess this has to do that there are plenty of good validators out there.
It's quite some work to keep a validator up-to-date. One issue with HTML is that there are many templating variants of HTML around, and for these files validation often flags problems that are false positives.

@scniro
Copy link

scniro commented Apr 27, 2017

@aeschli gotcha. I was hoping there could be at least something simple e.g. <div><div isn't a closed tag and flagged by the editor (similar to how Webstorm will do it). Thanks for the explanation. hopefully more requests for this will roll in but at this point I can't see it happening!

@alexdima alexdima added the html label Jun 7, 2017
@jbenguira
Copy link

+1 this is really needed

@alexkoffler
Copy link

+1 jumping on the this is needed train

@alexdima alexdima modified the milestones: Backlog, Backlog Candidates Dec 10, 2019
@JasonFritsche
Copy link

+1 Another vote for needed

arlosi pushed a commit to arlosi/monaco-editor that referenced this issue Oct 29, 2021
alexdima added a commit that referenced this issue Nov 5, 2021
Make it can be compressed by uglify-js
CGNonofr pushed a commit to CodinGame/monaco-editor that referenced this issue Nov 10, 2021
Webpack createChildCompiler api will drop SingleEntryPlugin complication hook
@NiravDoshi1305
Copy link

+1 Another vote for needed

1 similar comment
@jainharsh97
Copy link

+1 Another vote for needed

@silli-scale
Copy link

+1 for this

@hediet
Copy link
Member

hediet commented Feb 21, 2023

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@hediet hediet closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality html out-of-scope
Projects
None yet
Development

No branches or pull requests