Object doesn't support property or method 'remove' in 0.16.0 on IE #1357
Assignees
Labels
Milestone
Comments
|
@alexandrudima , note, this is a blocker for us in moving to Monaco 0.16.X in Script Lab. |
|
I can reproduce this as well (IE embedded control, Edge compatibility) |
|
Seems like it might have been this commit in vscode (PR 64099) /cc @sbatten |
|
@sbatten and me will work on a fix and publish a new version. |
rebornix
added
bug
sbatten
added a commit
to microsoft/vscode
that referenced
this issue
Mar 12, 2019
|
0.16.1 is published with the fix. |
|
Thanks, @rebornix .
|
|
It seems the auto update fails to publish the website (probably because I update the branch inproperly). I'll update the website. |
|
Website published. @Zlatkovsky thanks! |
anthonydresser
pushed a commit
to anthonydresser/azuredatastudio
that referenced
this issue
Mar 17, 2019
::SUMMARY:: Branch 627e7e9 commits: refs microsoft/monaco-editor#1357
GongT
added a commit
to kendryte/kendryte-ide
that referenced
this issue
Apr 1, 2019
68b13d123d debt - use dummy node instead of undefined to signel end
d0f56d8993 Fix #16099
4105ee1f12 show notification when formatter is disabled/uninstalled, message otherwise
966ba82947 fixes #71386
2681e564e7 move back to vscode folder
f5391c163f Compile sources before running
3611ff385b files2 - reduce legacy service code
9537ca4a44 debt - less casts
978a41a6bb electron@3.1.8
f0adc3936d Use VS Buffer
a42d4d21f7 debt - get rid of nfcall/ninvoke
84726e51f4 debt - merge extfs and pfs
519a5a8c5e debt - more async/await
f5554346aa debt - get rid of flow
64c3f1a93e debt - reduce explicit any or casts
4889af53ea Remove test trigger
e5316826f8 Add experimentalRefreshOnResume as potential workaround for texture corruption
ec0499a9dc Don't register "ini" for all files named "config"
ff47259fd8 Fix #71465 - "find in files shortcut broken"
2b518c120d Transform to Title Case
b71932d4b7 Merge pull request #70167 from irrationalRock/fix-59368
ff12b2a5d4 Version bump
617fc4934f Reveal Webview in active view column.
b8c2e7108b Merge pull request #71469 from Microsoft/roblou/ts341
3984e1cbb3 Take TS 3.4.1
bcbf1cae39 Merge pull request #70935 from iansan5653/master
f2f13ba21c files2 - throw if deleting non existing file
dbdb424ba8 files - use proper flag for writing in extfs
f4eae9a5f4 files2 - polish method names
7081def4a0 storage - remove global storage migration
9eec0c53b0 files2 - properly type the file operation event
4039ea8718 Revert "fixes #71163"
8b01096845 Fix starting path for save as in new window
f5044f0910 fix compile error
5ff938d303 force DA in EH
f2ba4c3312 Revert "files2 - throw if deleting non existing file"
3d6ece7a25 bulkEditService: throw if file to delete doesn't exist
e93ac37084 files2 - throw if deleting non existing file
94d07c7afd fix #71373
70a9ffc2ee fix #71369
0b66e3484e fix #71057
01470fbca3 Fix #71319
cfe613c05b revive the returned workspace identifier
666e7fa7ba update distro for OSS
292e59f367 fixes #70429
6dfc7094b1 fixes #71306
b5f5db349f Fix failed to create terminal for tasks
4df47201b4 another fix for #71140
d567b55427 fix #71298
9eb4d4e7e0 fixes #71303
d57b158fc0 Revert "Fix bad merge that caused reoccurance of 'Failed to create terminal for task'" This was a mistake. There wasn't a bad merge. This reverts commit 185e7002cbf1ef23d59d79bb3f99902c494f526c.
4b97e8ed7e "macOS" (#71228)
c2eb6f91e8 Merge pull request #71301 from Microsoft/joh/defaultFormatter
185e7002cb Fix bad merge that caused reoccurance of 'Failed to create terminal for task'
102a6920ce show status bar message when formatter is gone
2e38d5b740 default value for defaultFormatter is null
fc4981f512 only suggest formatters with main-entry
d0e21b9708 don't show a message when the defaul formatter isn't available
7887b6743a Fix #71313
9775e8e7a5 Fix #71313
2e6db8d955 Default to group 0 instead of active group
e5f4f84f3b Fix webview restore
fe699b5c1c Fix #69739 - Respect '..' and '../' in "Files to include"
de81ccf048 Fix #71155, pressing escape while comment is focused should hide it
5c0fc719a2 Fix #71138
b574eeaf66 Fixes #67214
9fd249ad85 Merge pull request #71292 from Microsoft:joao/fix-68385
52ec060807 Merge pull request #70127 from dlech/issue70126
af5582b28e Fix jsdoc
aba6af9c81 Make the default value of renderFinalNewline the same on all platforms (Fixes #70126)
19224a80f8 Fixes #69947
627c7f730a Add note about required window reload (#71228)
5b56e248c2 Avoid patching agent twice (#71228)
76e18d0915 fixes #71226
ab90aaf89d fixes #71250 fixes #71247
b1dafea8db fixes #71227
4891adbaa3 Ensure process os is set before xterm link handler is registered
692c89b1f6 fixes #71132 #71305
6b81670102 Handle ext host exit when debugging
fcb773d1ca fixes #71131
5cdd59f9c9 be relaxed when having one formatter and no config
d9c107cabd Fix #71156
63cca55cef only show picker when there is more than one formatter
50dfb5420a remove configure extension buttons, add configure default to format with...
af52ba713e fixes #71130
13583577d9 Fix Microsoft/vscode-pull-request-github#1080. Only rerender the widget when the position changed.
acddb5cff4 Merge pull request #71300 from Microsoft/joao/fix-69368
c09aac5dff inline PLACEHOLDER_URI
1eb58a1e78 fixes #70058
e4e0eb0637 add editor.defaultFormatter-setting, #71173
1134b21360 fixes #69368
5aedad1229 #71165 do not consider unknown markers in the count
1afeb46cc4 fixes #70902
11e98bd87e Simplify types (fixes #70491)
ddc39cb4dd fixes #68384
af30445fac Fix #70998
d9a72bc222 fixes #71104
325ef8cbfd fixes #71284
58a4260a20 fixes #68385
37c68c3a2d debug: fix pause action
3888555627 files2 - fix type of IStat to be as before
8c9cb842bd fixes #71280
1fc282fe17 #70998 Create output directoru before creating logger
1e96a51133 fixes #69932
b2a80a4d51 fixes #67317
7b9c3b0853 fixes #68176
fd2f43e602 fixes #71092
00c352d6e7 jsonMain message bundle load failure. Fixes #71144
f6c35e01d5 fixes #71288
b9a30cdca5 missing unused imports
f98cff8f06 fixes #70681
5663d6515a fixes #71112
bfb02a7d84 ...
310baf6d19 fixes #71206 fixes #71183 fixes #71092
9ce7505342 move - send a copy event instead of move when move is across providers
f2d1806816 fix #71140
25b96b66d6 mv - do not futimes on symbolic links
ff611c5374 typo
2f3f786193 Extensions are allowed to contribute shell and process tasks
06099f6db5 explorer: minor cleanup of unused methods
b0c18ef641 fix #71188
d275fe96d9 Fix #71099
6c6fcb733d fix #71195
732f666113 fix #71160
9120acebbb fix #71213
c07c843b1c files2 - some remote cleanup
e0e8a3348d fix #71203
1095dc2a97 fix #71240
5a7fd745dd fix #71212
58b6c82931 fix #71215
50c1d7daf0 Update simplified file picker setting to use a boolean
1bc278f36d Fix reruning of Custom Execution tasks
f611e0d63d Use host label for opening remote settings
112176384b windows is not symbolic link friendly
60fbccd0a1 files2 - use fs.symlink() for tests
3bd60b2ba7 Formatting tweak to "Running contributed command failed"
9f8de1f442 Fixes #71241, Adding a deletecommand to a comment alone does not reflect in the UI
f4e870fe86 Also support string in shellArgs passed directly to createTerminal
a4989579d8 Merge pull request #71127 from dlech/patch-8
28eb1684b0 add option to run DA in renderer
be7280d639 Fix checks for commentThreadHandle existence, fixes https://github.com/Microsoft/vscode-pull-request-github/issues/1074
d2ee1940fa node-debug@1.33.3
75e1e3a432 use case insensitive matches for server ready; fixes #71164
673134ab35 Send cursor to the start of the line for waitOnExit terms
addde0b36b files2 - mode => flags
c1c1f2b2af files2 - proper typing for resolveFiles
a3198370c8 explorer: disable dragging readonly items
63b80d0a4f build - disable another flaky test
193223a5ae fix #71152
bb35a1d223 fixes #71163
ecf3aaf96c fixes #71070
074257c836 fileservice2 - add a test for resolving symbolic links (file/folder)
3c67528470 Fix echo on custom execution tasks
9705ddc333 Fix missing properties in task identifiers
39f691ca0f Fix #71165
ed41004ade Fix #67498
54d37424c4 Merge remote-tracking branch 'upstream/master'
199461e1ec fix #71139
46fa864299 add folder to worskpace can lead to duplicate folders
779a1d3118 dnd does not preserve authority
e2183c1989 "remoteAuthority" is not recognized in code-workspace file
1e0f19dd3f Actions for simple file picker
2f2085f3e1 files2 - ensure to close handles even in error cases
b9bcca2b98 Merge remote-tracking branch 'origin/joao/snap-fixes'
d0211faa28 fix #71118
1579c1c522 Remove comment that shellArgs parameter of createTerminal does work in Windows
966b87dd40 Fix #71120 - incorrectly formatted uris in liveshare
03bdc72755 Update get system status command to get diagnostics
7c0068d6ed Remove unnecessary file scheme check in search
11efc39349 fix hygiene
117ee62c22 'html' snippet is annoying and easily inserts by accident when typing any html. Fixes #69457
44cf008419 update html service
5d4af57655 Update css service
3ba93e8aac Move more code to /common/
2b0b602af8 Update html service
02b8857896 Fix monaco compilation
6ff5ec216c fixes #68117
014c366fdc add _workbench.addToRecentlyOpened command
ee2f23192c open new window with reuse
0f45c39d97 status from ext host cli
9eb5669101 File picker undo should work (#70302)
a774363de1 fixes #68772
f64171940b node-debug@1.33.2
6876fcedc9 release debug API: parentSession arg for startDebugging
59a24aa10f Update cgmanifest for CSS grammar
81a7dff142 Fix #67273
61c990fb6f null guard for repl: copy
d70ae4ab0f Fix colorType check from bool to string comparison
8292829248 Explorations
1876bd1d38 fix compilation errors
6b43c6bfee enable no-nls-in-standalone-editor again
6d7959a938 console.log in tslint rule crashes ts server
6e72694a79 unblock ts language service
5e90625082 fix tests
31ddfc05b9 Move remoteAgentEnvironmentChannel to /common/
3342525669 fix #71073
78b4a7672c Merge remote-tracking branch 'upstream/master'
8399f4ae80 Have 'Format Document' and 'Format Document With...' at the same time, show message when formatting document with first provider, #41882
c98431ec76 #59478 Use file service to read user configuration
23ffed0344 update distro
0c50802a7a Reference proper npm package (fixes #52880)
2f38e3e72a Minor tweaks
78d62636f0 Move standalone editor nls calls to standaloneStrings which will be translated via VS Code
1c21692315 Fix task key creation
3d92b725b2 Fixes #71065: Bring back translation for standalone editor
f50b46c334 fixes #70985
78e61c63f0 register nodeless remote agent service
eaaf586d82 some jsdoc for #70231
fc7d4787ea proposed menu id: improve wording
480d54b546 fix #71055
bef602e832 Extract /common/ code
f3f8c576f9 enable forceConsistentCasingInFileNames
a8c7492752 fix casing issue
2c386fa9a3 Revert "Revert "debugToolbar -> debugToolBar""
afafc16dc4 fixes #69597 (#69628)
c4344fcd20 Make automatic task notification show up after a task has been run
21afd814cd Merge pull request #70521 from Microsoft:rmacfarlane/hidden-viewlet
56c0b50c09 Complete fix
fd77ea1e6d Merge pull request #70884 from Wimpressive-Snaps/snapcraft-update
f35466ac34 bulk edit - check for trash capability before using it
8288794f50 files2 - add trash capability (for #48259)
deab785846 files2 - implement copyFile across providers
3c136df8a2 move comments to browser (#70319, #69103) (#70939)
5688d00dd5 Fix #70156 - reveal pcre2 regex parse error
9231a581e6 Fix #70132 - allow opening files with ~ path in quickopen
65c437f085 Fix #70618 - show gear when hovering bool setting
01233c8ed7 Fix #70555 - don't hardcode panelInput border color
c840573f7f Handle an absolute path in quickopen for non-file scheme workspaces
60fd1c5931 Exclude unnecessary env vars when debugging
fb0573a38f Enable winpty compat only on Windows
07292fecf1 vscode-xterm@3.13.0-beta2
d25ea61e0c Add telemetry around localhost loading inside of webview
1d4c7fa5b7 some dialog fixes
33a1b96391 Add explicit index type
42f6d4648c Add trailing ... for command that opens a picker
f4921b0f20 Remove period from js/ts command title
2f0271b33e Fix a few implicit index accesses
eda154a129 Fix compilation error
7d0d7861a7 Introduce NodeSocket
29a4c6da20 Exclude buffer.ts from the monaco compilation
7f0737c5c6 :lipstick
904014567d Rename script
7b4c84f9b9 Add a script to automate generation of vscode dts for DefinitelyTyped.
54aba8ca73 Correctly reset progress flag when adding comments using old API
f832022ef6 fix navigation, modality, and confirm (#70937)
47d76f154d Fix search smoke test
fa1c88a4e1 Disable extensions in smoketest
65c775918b files2 - stub a createFile implementation
468260e6e9 Change isForeground flag to colorType with strings
96e7d6361f Update tests to account for use of undefined and RGBA
355021ec96 files2 :lipstick:
3c664cfe7d #70459 remove experimental azure search
8fc88c6dc6 Move ipc.ts to /common/
61766fa26d Remove logging
bb84f439b7 Enable no implicit any
750266fb8e menu: add proposed api check
b900b27812 Introduce VSBuffer
9bb443d153 Revert "debugToolbar -> debugToolBar"
73fc966280 #70352 remote implicit any
5595925f93 fixes #70423
91fac10f4e oops - check isEmpty correctly
e0c0e08569 Add extra timeout to squash flakiness
bed2921b47 Support remote user configuration
75bf16eb50 debug console: minor shortening
4fd781cdb1 debug console: Empty elements should not have dynamic height since they will be invisible
b4f27b843c files2 - implement basic copy of files without copy support via unbuffered solution
fa854de2af URI for waitMarkerFilePath
d5152c6539 breadcrumbs - fix open to side issue
01a3f15a48 explorer: when can not resolve root create a dummy error placeholder
dd35bbd8e7 Fix #70952
719556ec5f Add args to spawn call back
15a5decc3b Use shorthand
4d3b175049 noImplciitAny externalTerminal component
f012a60f63 :lipstick:
c793d1c727 Try moving the fallback simple file picker item to the end of the list
2e17ed25e6 Remove "calcAnd" from method names
5096a354b1 Prefer `undefined` to `null`
4fbd4725a2 introduce decent getSession(sessionId) API
6b3ac946bc Remove RGBColor and implement common classes
920493df97 debt - adopt splitview in references widget, nuke VSash
a42a1ffda6 Remove leftover log statement
a19adff38f fixes #70772
786a9e194c callh - make reference, definition, and call hierarchy peek mutually exclusive, #16110
e7ca7d5889 debugToolbar -> debugToolBar
b9a429222c run snapcraft as root
bfe030f543 output snapcraft version
98dd8a1fe9 Remove leftover console.log from tasks
a8d8813484 put warning about eager services
b84a549c5c add telemetry to know how often formatter choice is shown, #41882
2344aadeaf files2 - wait on legacy service to be there
a94502f9df no implicit any
d24ac8836c fix snap build
b56df1120b debug views: noImplicitAny
cd7c5e8e93 fixes #70931
bd8f6e25d5 files2 - create file service early on and register disk provider
36f4028227 fixes #70932
4cd3481c6a move main thread task to browser (#70319) (#70940)
e839c27b63 fix implicit anys (for #70352)
97cc9b15ba implicit any, #70352
72a0f77eb5 move main thread task to browser (#70319)
2699f06fb9 less implicit any (#70352)
5854b7a067 Add tests for 8- and 24-bit ANSI colors
29069ee900 Add support for 8- and 24- bit ANSI colors
9474154f13 Unit tests for matchesWords changes
8fd892f8a5 Merge pull request #70874 from mjbvz/fix-array-access-strict-null
0118588327 Fix vscode.newWindow args
1bccbd1cb6 Avoid sync stat call
4d81d14de0 Make updatePaths require TS 3.0+
25bfefce9e Make sure update imports handles js/ts directory moves
60c316f536 Replace `|| undefined` with `withNullAsUndefined`
31f4f3daa1 More noImplicitAny checks - #70352
5412e85864 Fix more implict any errors
d1e87a2dd5 More implicit any error fixes
1d97b72495 Convert undefined -> null in IOutputService
d58dcf2e40 Replacing null with undefined around `ContextKeyExpr`
91570a012a electron - better fix for dialog use
6982991b24 fix #70388
4fa2ccb12f dialogs - fix issue with message box not showing without window
809ccf9aa5 Fix #70912 - fix noImplicitAny errors in search land
7502b13ac5 files2 - fix tests
985a3f94b9 Fix windows shell helper disposal
38382b7077 debt - instantiate webview properly
46214c95f4 Use undefined instead of null for IEditorInputFactory
61c369b5ab Replace some instances of `|| null` with `withUndefinedAsNull`
86460b3fe3 Move tasks and taskConfiguration out of node
b5e512f2c4 compiler ftw
91eaf03502 Fix some strict property init errors
8235163d9b More implicitAny fixes
0999096ba7 Fix some noImplicitAny errors in our typings
53704af475 Fixing no implicit any in some tests
b4528f0a82 fix weird monaco-compile-check failure
c1de12f7c1 Fix jumping cursor on up arrow in quick pick (#70761)
c65cf48085 Explorer: adopt resolveMetadata property
70a5a89c4a explorer model: remove etag since it is not being used
71b4fc14c5 format on save, format on paste don't format when multiple formatters are available, #41882
e2096ecb4c simplify handling of synthetic document formatters, #41882
503910595f monaco.d.ts pain
3fc8913343 show quick pick when multiple formatter apply, #41882
0f8ba2f158 :lipstick: formatting
b206480e2c use LabelService in LoadedScriptsView
9d325a4d7e Wait for process ready before getLatency
eeaf5d876e files2 - implement copyFile support (same providers, copy support)
fcdb3e97d4 Fix monaco compile error
963bf55626 Merge pull request #70867 from mjbvz/tree-dead-code
931bd7e3f7 Fix for monaco
4ca31ee851 Fix broken tasks tests
245ce3ae21 files - proper size for content
bc0574de38 server-ready feature: better error msg when chome not installed
db0d1eade6 node-debug@1.33.1
0e24b75b62 explorer: should not reveal, focus or select roots
4244e0390c Merge remote-tracking branch 'origin/master' into isidorn/explorerExpand
639cc3fbd1 Handle composite tasks with a presentation and no command
bb0efb0ac2 remove remote channel contributions
95960cc231 expose settings path in remote environment
6cd919a545 move remote services to start up
7989e693b2 Remove crypto from tasks (#70837)
dc925370e6 add IOpenConfiguration.noRecentEntry
b19c690240 move remote connection failure notification as a contribution
d46aee64ff fixes #69950
4770cb0ec8 Merge remote environment into remote agent service
0b5933e144 Tasks should handle invalid regular expressions
c1e8c367f8 clean up
26b6ee1e8e create simple remote environment service in nodeless
4ab9e65031 async data tree: better node preservation through identity
d23187a9b7 object tree model: faster getNode
1ace7db1e9 make remote agent service disposable
c265338001 move getting environment from remote agent service to remote environment service
e764acdbb4 disable flaky test (#70887)
18c7f91484 files2 - implement moveFile()
5faf7c3539 Update statusBarItem.prominentBackground. Fixes #70845
50e587b273 Separate remote channel contributions from remote agent service
24e592c52c snapcraft.yaml: Add the url-handler
7f9406d777 snapcraft.yaml: Source Glib schemas from within the snap.
d99a7cbddb callh - better icons for calls/callers
9f80532dd5 callh - move context menu command above reference commands
354621d61c callh - persist view state when toggling between calls and callers
d5c14c6300 snapcraft.yaml: Fallback to XWayland if running in a Wayland session
e07c331459 snapcraft.yaml: Remove braces from ${SNAP} in command:
73b7ed584f snapcraft.yaml: Remove unnecessary data from the snap
c134334c4c snapcraft.yaml: Update stage-packages
e91b073155 snapcraft.yaml: Add the GNOME 3.26 PPA.
04639e468c electron-launch: ABI compatible GDK PixBuf modules
3f2b820b4c fix array.first
c8493b459f electron-launch: Create $XDG_CACHE_HOME
07f2bdc176 electron-launch: Add architecture detection
22dc561765 electron-launch: Correctly map the /snap directory on Fedora
16a06aceb3 electron-launch: Use bash
50d5be49fd files2 - introduce and adopt resolveMetadata option
f4f021ff56 Merge pull request #70869 from mjbvz/default-adapter-values
961e8ffab1 files2 - finish resolveFile(s)
9d64a3be86 Fix #27636 - in matchesWords filtering, split words on punctuation marks as well as whitespace (#70868)
14148acf21 Fix some sneaky strict null issues for array/object access
edd2c737f9 Use withUndefinedAsNull and avoid null supression
f1ab1ecb9e Remove unneeded short
376fca8645 Don't import 'vscode' in webview code
499cfbe8a8 Add fallback values for when exthost adapter cannot be found
0768663da9 Update js/ts grammar
60155902e1 Fix monaco build error
c112764d9c Remove some dead code in tree
872478caee IActionItemProvider should return undefined instead of null
5eeb74bbb1 Remove empty test
e7a7248009 Work on implicit any errors
8a8a502320 Rename fields
826dd8a35e Fixing some implicit any errors in exthost
28e6e12f29 Polishing port mapping webview api
e0427cdcb2 Working on public api for webview port mapping
311b64b550 :lipstick:
e27cd8db83 Prototype basic webview port mapping
fc10e26ea5 fixes #68505
05e606ef3d #59750 fix tests
713bd1e380 #59750 fix tests
155eab32e4 Fix #59750
bef32736a0 Fix #67415
aedd19d696 Better check for local file scheme in search
e44ea77199 Merge pull request #70798 from mjbvz/type-stub
0eaf7b7ed0 files2 - implement delete (without trash)
d8ea9d9dcd Fix null check in terminal
a136d24ffd files2 - implement support for resolveSingleChildDescendants
2042295b43 status pending entries :lipstick:
5f48c695de callh - show anchor as root node in tree, don't show badges, show current call path as meta title
5f09de6e7a api tests: avoid rootPath
f41af4f525 fix for untitled file URIs
eb169cae3c StatusBarWindowIndicatorMenu
9e984cd673 api-tests: avoid rootPath
e16115a0c3 exception widget: no max height needed
10834053f9 fixes #68654
9aa72db86b debug: simplify adding repl elements
bb38935fe7 allow file menu contributions
a8d3aea1e9 statusbarService: collect entries if not yet created
499686ca03 Send extension host exit code
2975db6be9 callh - hide "Call Hierarchy" command in peek editors
552d3a1ab5 Better track disposing
cffe0d632d move mainThreadConsole, #70319
2f157c7e45 move mainThreadExtensionService, #70319
a2f31e1cd6 move node/console to common/console, #70319
19466f3cad move broadcast service definition to common-layer, #70319
f94c73580f debt - use NullHeapService for now
6c59d053d5 move mainThread[H,L], #70319
f49b168fa1 Fix #70500
2db8170e09 fix tests
47fbe25748 fix compile
44ed24d5df files2 - implement resolving
cd10c5bde3 #70784 fix removing deprecated extensions on startup
5a920062da remove extHost-dependency from mainThreadLanguages, #70319
966050a653 debug: remove unused css, fix missing debug continue
8fc64ae3ce fixes #68739
0455fefeee add 'vscode.newWindow' command
819dda9bcc move mainThread[U], #70319
09f672c98b debug: Add support for sub-sessions
ae58c25e45 arrays.lastIndex
1d3215d100 move mainThread[D,E], #70319
2ab6546e02 debt - make url service contribute to opener service, #70319
ab1b6fc67a remove any in extensionsViews test
85afabd20e :lipstick:
c98957e6b5 bring back yarn cache
3ca0be9b94 callh - add count badge
005c5dbda5 files2 - implement existsFile()
6824561046 fixes #70812
1efaca21af fix builds
10c0126e4b debt - reduce null | undefined usages
a6e6fb201a Avoid any in TestInstantiationService.stub
eac048313a Add typings for simple `_` and other parameters that are missing types
e388c734f3 Allow searching in non-file scheme
904db5d8f7 Support measuring terminal proc latency
1f4d903569 Ensure comments that have pending text are restored
619f3201f0 waitMarkerFilePath to URI
0f8db6ff19 Remove duplicate text
b56ccfa83b Localize error message for comment thread add failure
b5ef5937d3 Prevent multiple empty comment threads from being created at same position
acd6c00729 Restore download-builtin-extensions task
7d0e64f5ec Strict null check VS Code
c51f04c97a Strict null check mainThreadComments
b6f756832e Strict null check commentNode
bf7f750a19 Add asArray helper
35068aeccd Remove IFileService.readFolder (fixes #69330)
e54f3d7e5d Use conpty by default on Windows Insiders
fe504e7136 files2 - createFolder can be removed from legacy services
1c710c65a8 move mainThread[L,T], #70319
c514d9e783 move mainThread[W], #70319
8237956caa move mainThread[M-Q], #70319
384773d4b3 make ts lint happy
e93063a0cc move mainThread[S], #70319
63f2d31d3f move mainThread[A-F], #70319
d1e6f624ef Merge pull request #70717 from Microsoft/tyriar/70716
beb89524b6 Merge branch 'master' into tyriar/70716
412a1074da moved mainThreadDebugService to browser
eddda708d5 files2 - mkdirp throws any erorr that is not FileNotFound
fc47f07c85 debug actions: final polish
0c203ce857 Respect usage of yarn with --ignore-optional
7dbe3bfa09 disallow vscode-dependency in extHost.protocol, #70319
57474cfad7 debug actions polish
dbaf6a97c6 Fail installing an extension if manifest is not found
d505df9f49 PersistentProtocol
356874ffb4 Merge branch 'joao/distro-fork'
d9e45c3513 debug: get rid of more actions
02381f00b9 move extHostCustomers.ts #70319
37b76b0889 debug: transform actions to commands and contribute them properly
cfd4cb8c81 strict null trouble
6c17a35f11 update strict null file
c92ce4014f move extHost.protocol to common, #70319
767606f83d fix build
71204c12d1 FileService2 - implement createFolder() (#70758)
7bb2bbd45d fully build
44f233e4e7 fix build
6c202fa7d1 improve logs
297a6be6b3 inline IRemoteConsoleLog-type, #70319
a2370138b4 some more named imports
f9c5362459 mixin before checks
0d1a6343b0 better error message
5c02b50383 extHost.protocol should not depend on extHostTypes, #70319
888415c12f move proxy identifier, #70319
b499142b46 Fix #70692
b5168be53f Merge remote-tracking branch 'origin/master' into joao/distro-fork
6dc70b0c3c applied changes to FindWidget
cefe51ded1 #70555 style inputs when search is in panel
ed1ae06b24 updates
1c937549aa better logs
63a3a570e5 strict-null work for configurationResolver; fixes #69683
42d1b15639 update distro
b61768007d finalize selection range provider api #67872
63ce59c390 Merge pull request #70748 from Microsoft/joh/callh
bc9a93e67b Require process tasks to have a type
0afa5f9e84 undo breadcrumbs change
d0c37911b9 support all peek/ref-view styles
d932b45148 Fix task.contribution.css path
84a482d7f5 move to include section
1bebb2409c server ready feature: fix #70537
79957814c2 #70332 Strict null check - complete preferences
fa3788471b #70332 strict null check - KeybindingEditor
6ca770ece4 Move some tasks files to common
bb8affc654 support stable peek for call hierarchy
7584c57cc6 fix build
901db1056b fix build
576f08a5a8 strict null trouble
eb80b12356 fix builds
f1f00a7d2b fix build
77972949ca tweek icon
c6fa07e62d use peek view theming
2d07ded94f bring in mixin as repo
b645c0cfdb persist layout info of call hierarchy ux
d9558862cc add uri-property to CallHierarchtItem, better wording, better behaviour when switching calls/callers
9017c54660 attributes: rtf files are not text
231ffd7df3 fix license
180aff2652 fix license
b3035a8566 render filename as backup detail
466e69b8ed files2 - always trigger activation event for fs provider, even if already registered
c0432ebae5 disable yarn cache
65ea2999de Merge pull request #70701 from penx/patch-1
d6bb61dd5b nodeless - add fileservice2 in browser
6e09c1d9d9 Revert "Revert "fix PR builds""
1d191e8909 Strict null check searchService
02423d3f15 Fix flaky terminal test
20cfb52ec1 Remove restriction on Find in Files
cfe6d2d89b More flexible find absolute path
8c0fdc2b9d Fix #69687 - strict null check search
30b2c30706 Add a command for deleting comment threads
44c1e0321a Support string in TerminalOptions.shellArgs
37cb23d3dd Unregister comment controller when it is disposed
4eb16c20fc Reenable localization smoke tests.
2d3d5df612 Fixes #62623: Python extension doesn't obey locale settings
fdf21e193d Fix #70330
2c137e16ef Add reverse and step-back icons
e92b32302e Pick up ts 3.4 rc
ea413aff57 add toggle action: calls from/calls to
3446f7fb49 Revert "fix PR builds"
65579c1715 Update .nvmrc
71858cf1d5 clean up debugToolbar.css
7717fc5812 show loading message, no result message etc
05f926991c debug: contribute commands to debug toolbar properly
6a5b2f14a0 Remove access to global default language.
18702b9a9e strict null fix
9208b8d092 allow for IStatusbarEntry#backgroundColor
cbe4cf4cca dispose on pressing X
959300f5f0 defaultFilePath can end up one folder too high
bd377076bc Fix icon name in rpm spec
6a065f46b5 remove column view idea
abae211aa5 add overview color, use proper controller, ignore peek config
b1ceace24d Merge pull request #70503 from Microsoft/isidorn/accessibilitySimpleNavigation
a92a5bf11f Merge branch 'master' into joh/callh
fc57815d08 strict null work
b77ce0933f call hiearchy like reference search
793f638d1b resolve document when running document sumbol command
102594e1ab debt - platform/node/files => fileConstants
96eb4cf00d proposed API: add parentSession to startDebugging; fixes #70219
7d20b64a3a Ensure that selection is good when the remote file picker is used
21ef762152 Merge remote-tracking branch 'origin/master'
8754c66d10 feat(coffeescript): Add `.iced` extension (#70686)
788301d0db fix PR builds
6906d7e3b2 disable horizontal scrolling in scm
1c4857aa4a fixes #70684
e6f7c49d7d :lipstick:
73ccd28be6 Merge pull request #70599 from MattIrv/fixDebugConfiguration
62874f8c81 Work on making sure code action requests are canceled when providers change
ed88edb8ef Make sure we dispose of lightbulb widget
504b058ec4 Update Comment Action Toolbar
a23f843bc7 Fix Unit Test launch configuration
06ac1a1dc8 use label when initialize
4828d90120 When updating style, use documentElement instead of body.style
e4ac6d29ac Update js/ts grammar
f87809dd9e Update comments for new comment api
579e4ac025 Comments should be in ctor comment thread
3207ea3b96 Merge pull request #62650 from beruic/patch-1
4f2dee5cfe Merge branch 'master' into pr/beruic/62650
8e00f39c5e Preferences strict null checks - #70332
4412367554 fix #70017
ea7c31d770 Allow tasks without a command
8b83141971 more column view work
93c77d5286 Fix undefined terminal when running task
9517c8c565 Don't include TS prefix in ts task's `error code` field
477fdb66ce Make sure we escape all new lines, not just first one
f996610bb8 Use toDisposable
31ee322630 Take title as input
0d7df6b7ac Encapsulate into StatusBarItem class
d107674164 Move show hide logic into HideableElement
7da5d30460 Move change detection into hasChanges
369f42dbed Init properties inline
151f478194 Remove unused methods
4e3ed34ba4 Fetch remote env from remoteenvservice
c03fd3f04f comment out potential crash code for now (#70563)
3297348cac fixes #66351
8f16a02e66 Move remote agent environment out of node (#70568)
40bcd6a242 use editor action, add context key for enablement,
31c1339b2c fixes #70107
5a88160c7d Fix #70385
689e1ca7d0 add 'callHierarchy.mode' setting with 'tree' or 'columns'
bb0587b384 show preview in tree-mode
c5585753a7 remove the setting to enable auto installs for missing deps
50f610fc55 fix strict null
3a3b62c1cb show calls as columns
3a71ae353c fix variableResolver
726c247efc nodeless - fix crash in minimap due to missing colors
4450acaabf :lipstick: simple file service
888080f8ac fix strict null error
751bb83476 nodeless - disable welcome page for now
b81ceba1ce strict null for extHostDebugService.ts
8c217344e7 prepare for strict null checks in extHostDebug
f051893f27 strict null for variableResolver.ts
4e542b4a3d #70459 make the setting internal and call it disabled
a1b5e8dc8a debt - inline (scary) stats.ts into diagnostics service where it is used
44ce1ce5fe Command and setting to install missing dependencies
7ecbbe4489 Strict null checks
0736c91f97 :lipstick:
1166dfb031 debt - avoid artificial ConfigurationWriter
7b6004f609 debt - move jsonediting/configediting to common
0be2e1cc5e debt - extract layout from workbench
18b926cd11 Merge pull request #70548 from Microsoft/sandy081/70546
ff898dd02c Remove unused code
38b9a27fa5 nodeless - lift file dialog service to /browser (#70541)
6c65a0dea9 fixes #70552
275fb51519 change missing deps to take only single dep
58340b9ad9 fix strict null checks
de771267b8 Strict null check mainThreadTask.ts
d6058d77c0 Improve extension activation failure messages
b01e65cf7f add action to context menu
48612205e1 Merge pull request #70502 from iansan5653/master
671f4f85e4 Mark fields as potentially undefined
416122eff7 Make sure we update status values properly for empty editors
e5463022e1 Show error if TS returns an empty refactoring
2e108cec4a Fix #70045 by reverting some of #67269
c5b2d047ec Fix custom viewlet not being shown when its cached views are not active on registration
1f64c12672 Use get/setAttribute() (#70477)
5c2a8f1624 Merge pull request #70507 from Microsoft/tyriar/lslinks
018989e81d Strict null checks
c33788349c Refactor for terminal links in live share
daccb87f92 CopyStackTraceAction use textResourcePropertiesService
c9a8a1d08f simple tree UX
73a4fa537e trees: automaticaly enable simple navigation for accessibility
de288947bc debt: create tree using instatationService
0250af0524 Modify / add tests for succeeding ANSI color codes
e7e2ce52b5 Merge branch 'master' of https://github.com/iansan5653/vscode
e156de1b98 Remove existing ANSI colours when adding new ones
2275bfe428 List of recently opened sorts weird. Fixes #70222
2d235fae55 [CSS] Update dependency for #68495
c2114abf72 Fix strict null checks in extHostTerminalService
d0e0aa2ddd Strict null check extHostTask.ts
b4d347d9f6 debug: move debugContentProvider to common
83c6c75b29 debug move callStackView
2f89a79efe api proposal, add call hierarchy contrib
3e414223fd scm: better preserve provider size when switching
1e69958136 Revert "remove 0 visible scm providers"
a93905ebf8 move debug files
2953bcfc3a IEmptyWindowBackupInfo.backupFolder should not be optional. Fixes #70322
1615a36eb4 Multi root workspaces: UNC paths get written as URI and not path. Fixes #70453
528526d5ff debug: use clipboard service
418470122b nodeless - fix baseUrl
cb71a9f7f8 :lipstick: build files
1b66cd7fb7 Strict null checks (#60565)
7f1108d74d Try to prevent incorrect inlining of this in configure tasks
d277e1a8ef Fix #70468
98ddfdd351 enable azure search by default
ee38239a93 debug: variable flash only when rendered for the first time
e2b8567514 #70459 Enable experimental azure based serch for extensions
7e4bac31d8 fixes #70258
c4c8b3deb4 cleanup
969bc0d7f3 remove 0 visible scm providers
b15e81b6b7 fix #70425
7258b995f6 Add userHome to IEnvironment
1ce2b64abb Use more explicit pending state to make sure we always cancel pending requests on cancel
2f7f2241c0 Don't reset state on cancel if another request has been queued
ed69ef2abe Just check if model is falsey
c4099c0fd1 Remove unused on-disk webview html file
5ef5fba39e :lipstick:
2401d09c34 Extract RevivalPool
d3443fd68d Fix strict null in remoteFileDialog.ts
f3f59aadc4 check if toggle reaction is available
528b422d92 strict null checks
58961de8fc command is renamed to select command
16f80d5b74 toggle reactions
5c2d728a99 Select command for Comment.
9f6d5c009e avoid redundant range update
51ba7278af Merge pull request #70090 from svipas/css-triggerPropertyValueCompletion-setting
cceda8e2f2 Fix #70389 - fix search smoke test
32afa6d121 Strict null work in comments
2d151ddbd1 Strict null work in commentsThreadWidget
7d3ef45bca Strict null check work in comments
96949bcc0e Strict null supressions in tests
ba569d8960 Strict null work on extHostComments
a51d518f58 Strict null check mainThreadComments
1e8d02112d Strict null auto add
17a8e27009 Move fallback button into file picker list
87e530da98 serverReady: try to listen only on the correct terminal
b1300a0904 Use extension point kind while checking for ui extension
ceb4b0c455 Introduce default extension kind to extension point
49dbd99813 fixes #70311
f6032213f4 comment out flaky test
40e20177ab Merge pull request #70402 from Microsoft/joao/build-yarn-cache
900f10077c fixes #70276
863c811b10 Fix #70404
f690bd5c28 Use artifact caching build tasks
206f38b5a7 fix snap build
b7f71db33f fix snap builds
73734fe339 strict null checks: contrib/files
2f6d567d1d strict null checks: debug
ad107b8a92 strict null checks: explorer
57ce1dfa2d strict null checks: debugModel.test
7b8af7a5ab adopt latest smoketest changes
58b7cc9ffa strict null checks: callStackView
471b98c102 don't make codeInset setting public yet, #70268
63642b538a Tasks with wsl.exe should be escaped like Windows
bb87ed8830 fix strict null
fb49355087 debt - use crypto.digest for SHA1 over custom solution
b79058ac28 Create panel part after editor part in workbench. Fixes #70264 (#70356)
c1d001a915 Re-applying Cleaning up reviver handling for webviews
d9bc0a186b Move details of checking for if should persistence into `shouldPersist` method
aa6995263b Extend disposable
4ed6571ddf Fix #69142 - Avoid updateTreeScrollSync when TOC doesn't have the same elements as the settings tree. And ensure that group counts are always up to date when refreshing the TOC
32dc72e557 fixes #70022
55706951d1 Fix webview deserialization
1e6206feab Remove the `useSameOriginForRoot` setting for webviews
ba644e53b1 Strict null supressions in tests
627e7e97e1 refs Microsoft/monaco-editor#1357
27a1eff190 Fix #70230
40ec20c38b Merge pull request #70269 from mjbvz/strict-extHostStatusBar
f50c390500 add BOM when saving a file when we know it (for #48826)
fabd88a618 update distro
e6a0c11578 strict null checks debugServcie
8d52ab850d fixes #70228
09b4daf0a2 use string undefined
134b3078df fixes #70065
f990f9a867 Use text encoder if available
6c72a0bf2e Do not cache icons which are not on disk
3c3e70b20f Fix switching drives with simple file picker
5b8482eb3e - use buffered output channel service for nodeless
04dbcafd35 strict null checks: debugConfigurationManager
1973e281a0 always run DAs in EH
0fffa26bc9 Enable overwriting of file with simple picker
efe38fc1f4 strict null checks: terminalSupport
630eb0efac strict null checks: debugSession
7ac3bf197a disable repeat for suggest messages, #65499
8b6c0c5ae5 strict null: loadedScriptsView
75e409514b remove accidental push of seperator to FileSystemProvider
8579e43df1 check parent range when creating selection range, #67872
a2f6ec675d jsdoc for #67872
52a923c4e9 fix #70288
b5c75f31ee strict null - editor service
4f8dbd4544 use a parent pointer instead of 2d array, #67872
a86ff6a4da Merge pull request #70224 from Microsoft/sandy081/adoptSearchViewlet
f072bc05ce fix compilations
8c55bd77da Merge branch 'master' into sandy081/adoptSearchViewlet
3017f8c6a6 strict null - all of workbench common/browser/electron-browser
bc3781cb24 strict null editor part
2cf174f040 strict null prep
5dd69eb47c strict null - workbench
49c10b9167 Strict null check editorStatus
c899a09a85 Strict null check extHostStatusBar
a60981dcb1 Fix simple strict null errors in extensions
e97cf685ae Strict null work on explorer and files
cb4b80be87 Fixing strict null errors in extHostApiImpl
02468f9129 Adding withUndefinedAsNull
9598b8d091 Add hasModel guard before using model
9cdacb46b1 Strict null supressions in tests
3b2287552c Annotate potential null values in editorStatus
12a48be8de More simple conditional guards for getSearchView
c34fa1b11a Strict null check mainThreadEditors
eb46b5b698 Strict null work in fileCommands
e0ff35f676 Strict null fixes for IEditorOpenHandler
2c70b5d506 Strict null check searchActions
2c6334154f Add conditionals for getSearchView
8052aa1d68 Supress strict null errors in textFile Tests
45d6f4225b Use IVisibleEditor
83a0776cbc Use helper for getting parts that we know are registered
ca6f648fa8 Type that all visibleControls must have a group and input set
159e3408c1 Use platform registry from views registry
2dd74a09c6 Merge pull request #69921 from mjbvz/strict-null-textFileService
e2f17d9693 Use basename as fallback for untitled resources
30395fee2a suggestFileName should not return null
53c0fdfdb8 Strict null check textFileService
787603c529 Move code action sorting into CodeActionSet
0e580b6ee3 Add CodeActionSet collection type
37167ef695 Use nullToUndefined more widely
794735f1d0 Add a helper to convert null to undefined
414aa83658 commentingRangeS
65ba7da691 Treat null as valid metadata property
c8ffa51ca4 optional commenting range provider and empty comemnt thread factory.
05efab0e4e Treat diagnostics recieved as js/ts init complete
3a19ca4cc0 Correctly ensure terminal links are not dirs
50ee8c5fa5 Fix TS 3.4 compile errors
aedc39025d update distro
ea6ecccb68 debt - avoid approot for resources in renderer (#70237)
a0407e3df8 Replace @@ICON@@
d551d612de Merge pull request #69931 from mjbvz/use-update-open
36fb7647d7 Flush buffer changes if we see the same file again
0e6496dff8 Don't add change if there are no changes
0aa886c72e Add undocumented setting to disable batched sync
d597028001 Readonly
4b9c55d14e Don't leak knowledge that updateOpen is special
2a5d86952a Use TS's updateOpen api to batch file changes
56055231cd Fix extra star in comment
b323af9096 strict null checks: repl
59dca36c22 strict null checks: debugEditorContribution
9bb8c5c60b strict null checks: breakpoint widget
73f233b872 Pick up new TS@next
11d538d933 Strict null cehck extHostApiCommands
963ddff246 Strict null check extHostLanguageFeatures
944b6eaff2 Merge pull request #69915 from mjbvz/strict-null-work-in-exthostlanguagefeatures
878eec7425 Strict null auto add
7ca85fed1f Fix #66614
d37e38b6c3 Revert extract and use null supressions as requested
9d503a5481 Naming
8ee3c9a484 Allow trackobject to take undefined
a92031dc02 Strict null check work in extHost and mainThread language Features
08dcd9e25d :lipstick:
10c2f55ecc fix strict null check
20726aba99 Adopt search viewlet to align with ViewsViewlet
6de764fb10 Strict null auto add
ecd66fdf7e take hideIfEmpty parameter while registering of view containers
063f0c1365 strict null checks: debugHover
f32ba85ea1 fix #57272
5a4c9902f9 fix #70218
3514e5c855 fixes #70198
b91ffcf44a Fix slash in tasks.json path caused by path migration
eff69bff02 nls - avoid string > 1000 chars
c56f557ef3 update telemetry for range formatter, knowing what extensions typically collide, #41882
84a6d429bb fixes #70117
f047436f85 send entries as object, #67650
c7ffcb9d0d Open vscode://file/<path> in vscode is broken. Fixes #69998
03073ed4a8 fixes #70058
b79b471f42 square brackets for workspace suffix
211e7cd1ba 'openFolder': add recentEntryLabel
37f689cebc remove paranoia code after fix for #69128
2c445297fb Fix #70077
80e10b8c65 monaco.d.ts BS
f9346fbcf3 add `editor.gotoLocation.many` setting that controls how multiple locations should be handled, #70032
a0e2879b0d Fix spelling of 'accessible' in task.json group enum (#70145)
ea854037b0 Selectbox: Remove explicit select role (Electron 2 workaround) (#70188)
8ec314aa0b :lipstick:
9658a61763 wip: async data tree should not use identity for equality
6892cfc90e for now remove SelectionRangeKind #67872
d77d8d5611 debt - restore used class
76c330c3cd electron 5 - bootstrap a nodeless configuration (#68302)
65ede5e23c Merge pull request #70150 from algoshipda/fixcommenttypo
2a559e6fef debt - some :lipstick: (no implicit any among others)
4276d2c34d Merge pull request #70071 from Microsoft/aeschli/recentWithLabel
a8db84c3a0 Merge branch 'master' into aeschli/recentWithLabel
860f5a9900 fix null check
aa639490f7 Merge branch 'master' into aeschli/recentWithLabel
327c33abb6 Merge pull request #70179 from Microsoft/aeschli/fix70006
1798032d00 window.ts is missing some type annotations and has errors. Fixes #70169
0d15584dad Unsaved files are opened in two windows when reopening vscode. Fixes #70006
6b6c4137ef add `noRecentEntry` for `vscode.openFolder`
402e8ea237 fixed-59368
22fdb8e2c3 bump electron@3.1.6
46e3bb36ee Fix comment typo handker -> handler
e7926ef76b fix bad strict-null file list
df2aeae19f fix #69941
0fca01c255 Bump node 2 - fix #69118
2fe0e23d7c Fix querybuilder tests
56425abccb CentOS / Fedora path to CA certificates (#52880)
6cc7eea6ed Ensure list of language ids gets populated when calling getLanguageIds before extension install/uninstall
bf5e12e923 consolidate search into common (#69614)
85d983391a move TMGrammars + Emmet (#69610)
6112a6a94a Strict null checks
cb5493917a Add css.completion.triggerPropertyValueCompletion setting
966cd549e6 Rename key, add distro update
789a267c1e Merge remote-tracking branch 'origin/master' into pr/beruic/62650
ef32b45945 strict null checks: watch expression view
304901a945 Remove now unneeded workaround to xterm bug
1c41ee34e1 vscode-xterm@3.13.0-beta1
ac46ca2a5e make caching more robust; fixes #69534
bd289999dd don't store empty label list
63d4b744fd Shower...
293deda00c store labels in windowservice
902740d844 cleanup
711f9a6b73 Load root certificates on Linux (#52880)
1790949939 Load root certificates on Mac (#52880)
637eef813b Load root certificates on Windows (#52880)
d17d223ba6 fix breakpoint enablment
9b39b7b1bc Merge branch 'master' into aeschli/recentWithLabel
6c2bca4b46 label polishes
c80a7601c7 strict null checks: electronDebugActions and variablesView
fa93b07de3 #49054 Do not hide in built viewlets
53c5277f14 debt - move workbench to browser
16635b8086 debt - move out more things from workbench
3a9341899a debt - declarative notification service
c32a7dea1c debt - declarative product service
694a366501 debt - introduce and adopt shared process service
6965f5ca81 fixes #68687
8b2ec5a1f6 Fix #69418
6a9c0580ec debug: better has / get map usage due to null checks
3f2c8900b1 explorer better expand to
5f407914d6 debt - declarative label service
347957ed66 debt - declarative lifecycle service
0a5289e957 debt - declarative request service
4df729ad13 debt - declarative IExtensionGalleryService
2d4fcf14d6 debt - declarative IExtensionManagementService
f1cd45c3dc fixes #70007
7ccfdd3a00 do not sanitize remote url
9fb1a067b6 Merge branch 'master', commit 'refs/pull/60640/head' of github.com:Microsoft/vscode into pr/60640
86ca253edf Merge pull request #60573 from scottymcraig/FixGitSpacesIssue
597d8da84a remove unused code
a488f9da9b Merge commit 'refs/pull/69979/head' of github.com:Microsoft/vscode into pr/69979
3385ec7341 debt - declarative context view service
c4de96ce75 debt - declarative context menu service
9b849d9de7 debt - ensure services for parts are there
15e3ec5533 Initialize viewletService in Workbench (#70010)
b263184273 Export Comment Thread
ac94f41e3b Strict null check keybindingEditing.ts
5390f0a899 Delayer for updating commenting ranges.
753187d9c4 Fix #69972 - use fsPath for untitled schema files
d880744019 Add test for #69972
7333aa8aee strict null checks: debugViewlet
31e7dc1722 strict null checks: debugToolbar
1592c3bcb6 strict null checks: debug quick open
6f946ab8d2 strcit null checks: debugEditorModelManager
0046a33fbf Fix fall error logging for setLevel
86526f401b Merge branch 'master' into aeschli/recentWithLabel
ff8afd07b8 label for recent
5c191f3683 strictNullChecks: debugEditorActions
0d9f226bfe Merge pull request #66819 from GabeDeBacker/user/gabrield/extensionCallbackAsTask
63773d5103 node2@1.32.0
8c5fe7e0db Disable default accept input command when comment textarea is empty.
75e711f8a6 seperate acceptInputCommand and additional commands.
c75557a01f Comment out failing tests
0e78411815 Fix strict null errors
87b337a8ad Use unique uuid for comment controller.
c2ff129097 Update Comment Thread label.
72a18e636b Add keybinding to show comment widget, make submitting comments a configurable keybinding
2a5cb0d30a fix typo #68557
286a61bd05 Clean up some comments/names
cd4c79975a add setting `editor.suggest.filteredTypes`, #45039
1cb20c7d79 more option rename...
00ead383df use async version of fs.exists; fixes #69860
68842a0c3e debt - declarative extension & extension enablement service
3bc9424abf debt - more declarative services
76b5214ef1 debt - all workbench parts are now declarative
d9ed5aac45 debt - declarative keybinding service
5103a2f61e Fix #69495
a147afbae4 debt - declarative viewlet service
667868b5ec debt - declarative panel service
7eae6fed8f debt - declarative views service
0424ae8f48 Merge remote-tracking branch 'origin/master'
721e3cf669 Merge branch 'joao/scm-views'
f15e1b7d23 the ids of extensions clashing, #41882
ae185fc6ce fix order for default scm views
aec5806150 scm: fix actions context
b36a855c6a wip: scm using contributable views
59681e54e3 :lipstick: rename setting to maxVisibileSuggestions, #68557
bb750dacd4 add CompletionOptions with support to filter by completion kind. Will make it simple to implement #45039
96a2e5e16a Simple file picker should respect filters
a014858074 strict null checks: debug commands
6fe9c0f87c strict null checks: breakpointsView
04f7485615 debt - acitivtybar as declarative service
c056a5da5c Fix #69760
248d000108 tests #69760
34c5f82249 debt - declarative file service
614598631d debt - declarative editor services
3190c25299 Merge pull request #69942 from svipas/max-suggestions-to-show-and-icons
2a6b0dedb6 simplify icon style logic
7b45f26827 debt - use SyncDescriptor for editor part
003ff303de strict null check: debug actions
e9f899f5cc debt - register accessibility service declaratively
8eea644e05 debt - getPinnedViewletIds() should really not be on IActivityService?!
b329bf4c89 debt - allow parts to register with the workbench and adopt for title bar
a6e596d755 debt - use more typed service identifier
cecd82a217 Remove unused showIcons var from suggestWidget
ea9d2fe9f6 Use onDidChangeConfiguration for showIcons in suggestWidget
9cf05c9748 Allow to install language pack extensions always
967b46a3db Prevent simple file picker from matching on the folder name of the parent folder
022fb7d434 debt - part implements ISerializableView
f07c7d7056 Add validation messages to simple file picker (#69905)
0e409ed152 debt - simplify part layout
73a83d33c9 Replace much with many in commonEditorConfig for maxSuggestionsToShow
1924c39136 Improve simple file picker accept tooltip
8e5484fec5 wip: more SCM views migration
e8754369ba dgpr declare, #67650
2f74d3a82d fix panel view layout order
5384995ea7 Replace iconsInSuggestions with showIcons in suggestEnabledInput
a3b5a8f724 Fix completionModel tests by adding missing properties
67d2fe67f3 Use showIcons and maxSuggestionsToShow in suggestWidget
5a62ab1b97 Add showIcons and maxSuggestionsToShow in editorOptions
04c9c8c8c2 Add showIcons and maxSuggestionsToShow in commonEditorConfig
91411b055f Add showIcons and maxSuggestionsToShow to monaco typings
a50020021c Fix #69940
5a552a4734 Listener leak alarm for `onThemeChange` Fixes #69896
0697b3a55c :lipstick:
eb12756d0c debt - part service => layout service
93b197674f baseDebugView strict null checks
ec10e5b273 debt - partService is really in browser
ac5ef12529 fix #69867
0955124cd7 dispose menus
a09e7bd128 Fix #64575 - delete FileIndexProvider
fc859f29a3 Tests for #69739
f1cc26006c Fix #69739 - allow searching with ..
49fa87ea3e Fix #69623
24837e3cb7 Better default behavior for invalid setting enums in gui
4f2a03e5fb Fix #67656 - less unnecessary refreshing in the settings TOC
782d9e1401 Fix #67452, fix #67462
a224fa02ed Use IDisposable from lifecycle
4638ce1af6 Fix strict null error
03c4f88d7f Strict null check mainThreadWebview
6c2135e8cc Update distro
2d209b2eab Strict null check codeInset
9c29584321 Strict null auto add
e12ef1bfa6 Strict null check remoteFileDialog
9eab7c885e Strict null supression in test
9e5f157bb3 Small strict null fix in workbench.ts
a759b9265a SettingsEditor#renderTree is not async
d59d014ece Fix #69297 - settings editor dropdown issues
837907545c Strict null work
d2902a7f6a Revert api sketch
40c13edb98 Use glob for terminal strict null include
d315d18dee Merge pull request #69799 from Microsoft/rebornix/commentenhancement
b64a7295b2 Merge remote-tracking branch 'upstream/master' into rebornix/commentenhancement
2a2f817990 Use the updateOpen TS api to sync multiple changes in a single file
ba0f67f828 Fix warnings
013501950e Auto marking private fields readonly in vs/editor
d14eab580e Auto let -> const in vs/editor
e80300adbe Auto let -> const and auto mark privates as readonly in vs/code
ce1cb8a9fc replace draft properties with labels in CommentThread and Comment
9cdff80e19 Make sure to dispose key press event listener in dispose as well
ac9c1d2615 Remove CPP tools from built-in json
6d665482c8 Put back more of the terminal changes
a4b49166d0 Fix #69110
905248fa6e comments panel handle new comment thread registration.
d5e4009ae9 Remove need for acquiring dimensions for terminal from main thread
4bfec9c80f Make sure we match whole file name for config file
c93f5e3560 Use regular expression to identify config file names instead of singe file name
99cf5e4881 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask
6da595150d Fix simple file picker in empty workspace
6784a0bd27 Strict null check settings files
663eca8ace Removed Snap related code from updateService.linux.ts
42194d82a1 Callback for creating new comments
9a72cf08e4 null checking in debugger.ts
b91adad1cf Fix file ordering issue in simple file picker
84b046ce10 debt - introduce ILayoutService
991d836c11 Comment a struct null check false positive
2f62d28548 debug/terminals.ts strict null checks
7866a0a974 null checking in debug/common
672b272fa3 dont use super and async/wait...
8b1b0763a3 Merge with master
763ae0943d eng - some extHost strict-null work
2b9aeb26ff wip: scm views
95e877dbcf more declarative service
c7622aa809 Merge pull request #69532 from Microsoft/aeschli/saveUntitledWorkspaceOnRenderer
255c13efaf Merge branch 'master' into aeschli/saveUntitledWorkspaceOnRenderer
40905b95ac eng - strict null checks for remoteFileService
26f0a77c56 Make simple file picker case insensitive
0fa822f7d5 add newline and warning-icon before the path, #69044
74955b29d7 send raw timer ticks, #67650
beca500a38 debt - remove startup type logging
1b681fd98d showItemInFolder with URI
4159cb41d3 Fix #69205
cd816afcc9 Take static arguments for the view descriptor ctor
97efb5af57 fix #68421
df93a3767f fixes #69589
e6bc6699a4 strict null checks: extHostSCM
764d2e9487 fixes #67722
1d345f0737 URI always needs to be revived after crossing ipc boundaries
dfb934c319 Add a context key expression mapper
caa10c9d05 Simplify the Protocol implementation
c4bed46784 Add a download util that uses a separate process
ec878903e9 Fix #69849
0b9e2a1c8a If the code editor is readonly still alow bulk edits to be applied
556bfbeee6 fix #43270
bf54e67a03 Merge pull request #69861 from adamtajti/remove-duplicate-config
92629f3f5f findFiles tests
0710a009f8 Fix #69875
1adb3256ea Show a quickpick for changing display language (#69570)
38c3f4bede Use config file diagnostics provided by TS Server
608fc2cee2 Auto convert let -> const in base/node
3f93ea6521 Auto convert let -> const in base/common
52556f9742 Auto converting `let` -> `const` where possible in mainthread and extHost
aef80e8070 Auto marking fields as readonly in mainThread files
ff1d530157 Strict null work in files/browser
db9a994ded Strict null check extHostDiagnostics
14c4fde6d6 Strict null check extHostQuickOpen
8f3cda12e4 Strict null check extHostFileSystem
bb64391ec4 Strict null work in exthost
733a1cd841 Strict null check extHostDocuments
480b838ef2 Strict null check apiCommands
e3964c95d2 Strict null check webview
6770dd762d fix/69830
10fdea204a Fix #69840
f3b73b1abc Fix #69862 - don't split comma-separated globs when expandPatterns is disabled (for findFiles)
8764eaf579 Fix #64749 - firstVisibleIndex in tree should consider element midpoint
b7673fb6f4 :lipstick:
d862e3217a Fix #66796 - previously there was weird listener behavior described in that issue but it has disappeared
37732e9ced Strict null check titlebarPart
f521072ecc Strict null check configurationEditingService
a6c498b74a Strict null check fileService
1f2dca36d9 Strict null check textFileEditor
13e394ff45 Strict null fixes for tests
39e7e1f339 Strict null work on markers panel
bde0b86400 Strict null work in contrib/preferences
81b713fe6b Strict null work in extensionEditor
9289478127 Interpret NO_PROXY (#68260)
3b451a68ba Fix strict null conflicts from making openEditor return Promise<Editor | null>
20dfc77b84 update inputbox
9fa249ae94 Strict null work on mainThreadSaveParticpants test
3cf67b0b7d exthost types, avoid using enums
311a05ddf1 Fix merge conflict with rename
dd39966615 Strict null check mainThreadHeapService
3f737ae1c7 Strict null check textModelResolver
7d88452059 Strict null check mainThreadSaveParticpants
181ab9f3db Strict null work on editorService
d3f079fd7a Mark fields readonly
713b178898 Strict null work
3bb9487c4f Strict null check backupModelTracker
243d3a482b Strict null work in menubar
6f6aa56275 Strict null work in keybindingsEditorContribution
6937635d1d Supress some strict null errors in mainThreadSavePartcipants
0589591234 Strict null work in editorGroupView
a5d63ae52e Strict null work on tabsTitleControl
50d502af61 Strict null check title control
3183a7a0f0 Strict null check breadcrumbsControl
a588a963fa Strict null check panelActions
b76fecb413 Strict null check listCommands
aa912c88ed Strict null check activityBar
84c059ab52 Strict null check editorActions and editorCommands
7e05804a90 Strict null check compositeBar
367b5fc7ec Strict null check editorDropTarget
ee75807070 Strict null check activitybarActions
2f088e6d96 Strict null check fileEditorTracker
def06bab48 Strict null check customView
a6dee4c407 Strict null check textDiffEditor
873b17fce6 Strict null check dnd
314564c591 Strict null check diffEditorModel
d52d4bb0fa Strict null check untitledEditor
2f4ee72b2a :lipstick:
4a8d7b7080 workbench - move restoreTimeoutHandle to a better place
1251a5094d Revert "fixes #68549"
2f0fdae41d Cleanup: Remove duplicate configuration from outline.contribution.ts
a3817504c4 fixes #68549
c2522605d9 Merge remote-tracking branch 'origin/master' into pr/beruic/62650
41d0633196 Address code review feedback
bf9a27ec01 [Debug] Filter "Call Stack" panel based on thread state
fc277b039b Fix #69521
b5b811980f Remove IWorkspaceConfigurationService
a40b2ae4d8 :lipstick:
66b45946a1 fix strict null
849d9417ea [json] fetch http and https schemas on the ext host
998b70c7e2 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask
c6315a3d30 debt - more services cleanup
f0983abe97 Fix #69681
ce3f0c17d7 [json] update service (webpack)
8e986b18a0 [html] update service (multi semantic selection, webpack)
c9370aeaf1 [css] updates service (multi-semantic selection, webpack)
f7f4357b9f services - sync descriptor for notification service
3c209bdc83 fix #65997
f9bda10403 debt - extract a telemetry workbench contribution
e8e7703ab4 fix #69406
ef20041efe use IWorkbenchThemeService as import
54da2fb645 :lipstick:
3996321aaa fix compile issue
532213ed26 :lipstick:
480e15ca4e fixes #69112
a3ce5141e3 remove base64 transformation in electron IPC
6c52d4856c Merge pull request #67155 from pawelurbanski/1.31_accessibility
c145eedcea cancel requests when outline provider change, also retrigger request #69147
20a4f36e25 add workbench/contrib/scm to strict null checks
94f7ae74c5 fixes #69529
fe2571f087 #68546 Tests
2b98f57145 fix #67300
8f0c07ac9e Get rid of editable map, it should not be a map but just one element
3021254e19 Merge branch 'pr/60426'
4f197a7079 :lipstick:
0bb3bfc4b4 strict null trouble
e1dac9dee1 files - do not focus explorer when revealing folder (for #69333)
3d9d4e18c3 debt - IActiveTextEditorModel => IResolvedTextEditorModel
809297c9cf only alert when inserting a suggestion make additional editor, like inserting an import statement, simplify the message that read when selecting an item
9834042b3c Merge commit 'refs/pull/60426/head' of github.com:Microsoft/vscode into pr/60426
e5d9409ab7 undo aria change
3d3450cc95 Fix #68546
de8f1b8025 reset editor selection when explicitly cancelling snippet mode, #68512
1eb6de1daf clean up some todos
10cd21c637 better error message for #68744
4e3dcb718b Update preferences.contribution.ts (#69807)
105f4f84fb more strict null
3f68665c30 strict null - contrib/outline
31f6902afd exploration - auto release after build
f03dbf34a6 Merge pull request #69701 from tamuratak/make_error_message_easy_to_understand
73ff13f5de Merge pull request #69816 from Microsoft/tyriar/69115
3a10272f1e Create browser/terminal.contribution.ts
ff5ae22403 Remove more from electron-browser/terminalService
437f7f67cb Move TerminalProcessManager, node->browser
6d5ab922e6 Move terminalProcessExtHostProxy, node->common
03f23ddbc6 Remove duplicate getWindowsBuildNumber definitions
b5a06ebb62 Move terminalInstance, electron-browser->browser
23fbca34b0 Break node dependency in TerminalInstance
877f0905ac Move terminalProcessManager to node
d9af6b90a0 Remove execFile dep in terminal instance, unify 2 path prep functions
56303b0c2c Merge remote-tracking branch 'upstream/master' into rebornix/commentenhancement
415c08825d Move a lot of terminalService to common/browser
00f5bdb0ba Move terminalCommandTracker, node->browser
b5dcee0a31 Move terminal CSS and images to browser
1d1dbdc494 Move TerminalConfigHelper, electron-browser->browser
2675ffeaaf Move parts of terminalService up to common/browser
3760c273fa Move terminalPanel, electron-browser->browser
5b7bdaccde Move terminalActions, electron-browser->browser
e78c2e2a21 less verbose comment controller api
badedf5d7d Move terminalEnvironment, node->common
cc7349745d Merge remote-tracking branch 'origin/master' into tyriar/69115
f40bd2f60e Merge pull request #69814 from Microsoft/tyriar/snc_terminal
8afa7773d5 Remove os dep in terminalEnvironment
d416cd584f Merge pull request #69815 from Microsoft/tyriar/69107
5d2a154da6 Add terminal-specific tslint rule to allow vscode-xterm imports
fe169ce4d2 Move terminalLinkHandler, electron-browser->browser
08f1e188f6 Rename contrib/execution to externalTerminal
d93221d7d5 Strict null check contrib/terminal
47977b9914 Merge pull request #68489 from jeanp413/fix/terminal-rename
0e5614f002 change the message to clarify the intention.
62a1cd9b9c Merge pull request #69722 from Kedstar99/Fix69583
da85a2c302 Handle error in getCwd for Linux
1eb7e38b6d Correctly set disposables to undefined
fc860b8c0a Fix for bug 69583 to use a mechanism that is more Linux compatible to get the value of the cwd for the integrated terminal
b8a184d998 Mark windows shell helper as | undefined
53ac75cd9a Also dispose windows shell helper
7196e873f2 Merge remote-tracking branch 'origin/master' into pr/jeanp413/68489
952af6e681 Merge pull request #69690 from mjbvz/strict-textmodel
e42c30a294 CommentController.
02a6339139 Remove most null supressions
6c5aadb0c2 Re#69258. Another typo.
15585b542f Merge pull request #69079 from irrationalRock/fix-62968
a3385c0721 Merge pull request #69258 from khaled4vokalz/master
f8d688f0c5 :lipstick: IPartService
4b1c338a8f improve launch.json schema for serverReady feature
13a11b3931 debt - split more layout things out of workbench
5b324d0aa6 Merge pull request #67511 from flurmbo/debug-console-ansi-italics
9c77fb324f Merge pull request #69049 from Microsoft/tyriar/terminalPanel_snc
64748589c5 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask
0ba7481840 Add JSDoc for process or custom execution completion
d9aeef5de6 remove hasChanges-check, fixes #68971
07e498f887 Add filename selection and extension to simple file picker
d9ad6ae112 Merge remote-tracking branch 'origin/master' into tyriar/terminalPanel_snc
977f414c20 Strict null check vs/workbench/contrib/tasks
6fad3377f4 Start CLIServer with extension host
44b4f0e967 remove isMalformedUri thing
30e74b1468 debt - layout => legacyLayout
a09fc246ed remote - workaround issue with dialog channel
ec70dcd87a Fix #69684
0a1e5ea6d1 #69689 Fix null checks in other files depending on output
979273be96 Fix #69689
6877b80957 update strict null file
9638b09920 :lipstick:
d30f41aa40 explorer: for collapsing directories react on keydown events
97b4dc8b00 Throw an error when renderer exit is called on a non-renderer only terminal
5da21fb665 Allow undefined exit codes to be logged
f2a58a6b85 Fix press any key event handler leak
19dc5cdf5a rename finishedWithRenderer to rendererExit
0d585db3b0 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask
4c593835a1 fix compile error
ceb8d830f8 Move welcome page and walkthrough to 'common' and 'browser' (#69116)
61d7bc4b26 adopt shared registerAction-function, #69036
fc1c69ccaf strict null trouble
64f715b1e9 move registerActions to common/action.ts, #69036
d2239c2473 uris without scheme and without strict-parse fallback to the file-scheme, #66802
88c1f67f64 Move watermark to 'browser' (fixes #69117)
472a1abbe2 fixes #69667
ca0b1b38b0 debt - make target location optional and let service decide
265644d08a debt - use our assert util
5518580b30 Make list.inactiveFocusBackground null by default (#69673)
a731d2e288 debt - move more services to use registerSingleton()
fea4aae064 Merge pull request #69775 from Microsoft/isidorn/doNotFocusAfterPromise
489dfec1e9 fix #69141
a1481e3e2e Switch cpp and c grammar to jeff-hykin/cpp-textmate-grammar
5893ace5c1 fixes #69755
baf256a71b debt - move editor layout event out of workbench
bc8f09709e Merge pull request #69726 from MOZGIII/patch-1
2469f39a58 :lipstick:
5f54123a0c make IPreferenceService use sync descriptor, #69226
d88970796e storage - getInteger() => getNumber()
bf8c66a079 fix #69753
595ac89613 debt - move more things into workbench state object
4c73306922 Merge pull request #68653 from gmertk/feature/workspace-snippet
6311e9ba1c fix compile
c10ea17d96 Syntax highlighting and check for .ipy files. Fixes #69694
d43c6181ee Merge pull request #69735 from runtimerevolution/laginha87-folding-range-doc-changes
f6703e5042 debt - group context keys in one place
cdbe7bff05 resolve #69734 on master
2702c1421c debt - work on untangling layout things out of workbench
def23176f2 Update vscode.d.ts
eb17fc81bb Fixes useExec promise not returning if there's no work to do
e96ab81392 extensionTestsLocationURI.fsPath normalizes path (for #69569)
02ca5bde96 Make an error message easier to understand
1e17319bfd fix #69588
739a9dd5ce debt - dragover needs preventDefault()
c9ebd2e15a nodeless - move window.title setting to workbench.contribution
51891b88b9 nodeless - set good default zoom factor
9c1b8851eb :lipstick: imports
900d58bfe5 debt - declare more services via registerSingleton()
4585f69a82 fix compile error
e4b70bca4a fix #69334
ba066625bf :lipstick:
b0bd70e6d8 debt - Buffer requires /node/ layer
0e6253f84a fix #69328
a0851ca719 Strict null check textEditorModel
c5e999376f Fix strict null error in performance
74e525d78f Strict null work on api tests
326660dddd Strict null work
a733b47750 Strict null work in br…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
monaco-editor version: 0.16.0
Browser: IE
OS: Windows
Steps or JS usage snippet reproducing the issue:
1.) Go to Monaco Editor Playground in Internet Explorer
2.) Right click inside the editor to bring up the right click menu.
3.) Attempt to left click to dismiss menu.
At this point you will get the following error:
The text was updated successfully, but these errors were encountered: