Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed various HTML errors with the various webpages #1309

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Fixed various HTML errors with the various webpages #1309

merged 2 commits into from
Mar 1, 2019

Conversation

Kedstar99
Copy link
Contributor

There are some validation errors with the monaco webpages (and others).

https://validator.w3.org/nu/?doc=https%3A%2F%2Fmicrosoft.github.io%2Fmonaco-editor%2F
https://validator.w3.org/nu/?doc=https%3A%2F%2Fmicrosoft.github.io%2Fmonaco-editor%2Fmonarch.html

https://validator.w3.org/nu/?doc=https%3A%2F%2Fmicrosoft.github.io%2Fmonaco-editor%2Fplayground.html

This PR fixes all the errors apart from the following:

  • The link to download the latest version uses the characters '{' and '}' in the href attribute. These aren't valid according to the HTML spec, but I assume these are substituted in by another program.

  • A warning for section id playgroud about missing headings

I hope this is useful.

@alexdima alexdima added this to the February 2019 milestone Feb 28, 2019
@alexdima
Copy link
Member

alexdima commented Mar 1, 2019

👍 Thank you!

@alexdima alexdima merged commit ef9c54d into microsoft:master Mar 1, 2019
@Kedstar99 Kedstar99 deleted the HTMLFixes branch March 3, 2019 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants