Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to close the detailed documentation view #1185

Closed
anatsegev opened this issue Nov 14, 2018 · 1 comment
Closed

Failing to close the detailed documentation view #1185

anatsegev opened this issue Nov 14, 2018 · 1 comment
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug suggest
Milestone
October 2018

Comments

@anatsegev
Copy link

monaco-editor version: 0.15.1
Browser: Chrome version 70.0.3538.77
OS: Windows

Steps or JS usage snippet reproducing the issue:

Open the detailed documentation view.
Click on the 'x' icon to close it.
The view stays open.

image
@alexdima alexdima added suggest bug Issue identified by VS Code Team member as probable bug labels Nov 14, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Nov 15, 2018 •
edited

Broken by microsoft/vscode@b77b9af#diff-caac303ecc98a837b262c2c9a093026d cc @bpasero @ramya-rao-a

@joaomoreno joaomoreno modified the milestones: Backlog, October 2018 Nov 15, 2018
joaomoreno added a commit to microsoft/vscode that referenced this issue Nov 15, 2018
@joaomoreno
fix suggest widget in standalone editor
2e30d00 
fixes microsoft/monaco-editor#1185
fixes microsoft/monaco-editor#1186

cc @bpasero @ramya-rao-a
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug suggest
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
4 participants
@joaomoreno @alexdima @ramya-rao-a @anatsegev