Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot resolve dependency in monaco-editor/esm/vs/language/json/monaco.contribution.js #1178

Closed
adam1658 opened this issue Nov 13, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone

Comments

@adam1658
Copy link

monaco-editor version: 0.15.0
Browser: N/A
OS: macOS 10.12.6

Steps or JS usage snippet reproducing the issue:
After upgrading to 0.15.0 I can't build (with parcel) because of a weird looking import path in node_modules/monaco-editor/esm/vs/language/json/monaco.contribution.js - it starts as follows:

import './....editoreditor.api.jsapi';
/* ... */

If I downgrade to 0.14.3 again it works. See the beginning of monaco.contribution.js in 0.14.3:

import '../../editor/editor.api.js';

Is this the result of a dodgy build?

@alexdima
Copy link
Member

That is definitely broken. This was the first built I did on Windows in quite a while, I guess some of the build scripts are not working so well.

@alexdima alexdima self-assigned this Nov 13, 2018
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Nov 13, 2018
@alexdima alexdima added this to the October 2018 milestone Nov 13, 2018
@adam1658
Copy link
Author

Thanks for the speedy fix @alexandrudima!

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

2 participants