Skip to content

port: [#6531] Prompt validation of confirm prompt in chatbot is not working for newly added language (#6554) #4369

Closed
@github-actions

Description

@github-actions

The changes in [#6531] Prompt validation of confirm prompt in chatbot is not working for newly added language (#6554) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6531

Description

This PR adds the new RecognizeLanguage property in the PromptOptions class to be used in the onRecognizedAsync method allowing a different language than the one determined by the activity.
It also updates the onRecognizedAsync method of the ConfirmPrompt class to use this property solving the issue when a ConfirmPrompt is used along with a TranslationMiddleware.

Specific Changes

  • Updated PromptOptions class adding the RecognizeLanguage property.
  • Updated the onRecognizedAsync method of the ConfirmPrompt class using the new property.
  • Added a unit test in ConfirmPromptTests to cover the new test case.

Testing

These images show a bot using the translator service and the confirm prompt working as expected.
image

Please review and, if necessary, port the changes.

Activity

added
ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.
needs-triageThe issue has just been created and it has not been reviewed by the team.
parityThe issue describes a gap in parity between two or more platforms.
on Nov 18, 2022
added a commit that references this issue on Jan 4, 2023

port: [#4369] Prompt validation of confirm prompt in chatbot is not w…

fe88652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.needs-triageThe issue has just been created and it has not been reviewed by the team.parityThe issue describes a gap in parity between two or more platforms.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @JuanAr

    Issue actions

      port: [#6531] Prompt validation of confirm prompt in chatbot is not working for newly added language (#6554) · Issue #4369 · microsoft/botbuilder-js