Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generating source maps when output-dir specified #538

Closed
dgobaud opened this issue Feb 5, 2019 · 3 comments
Closed

generating source maps when output-dir specified #538

dgobaud opened this issue Feb 5, 2019 · 3 comments

Comments

@dgobaud
Copy link

dgobaud commented Feb 5, 2019

I'm using 1.1.9 all is good thanks to https://github.com/Microsoft/appcenter-cli/blob/v1.1.9/src/commands/codepush/release-react.ts#L132

I see you've removed this though in 1.1.10.

One problem is you ask for an output-dir and then generate a bundleName based on iOS or Android.

But sourcemap param wants a filename not a bath so we need to know the bundleName ahead of time.

You should change --sourcemap-output to --sourcemap-dir and generate the sourcemap file automatically to match the output file name based on the iOS/Android platform

@dgobaud
Copy link
Author

dgobaud commented Feb 13, 2019

App Center upgraded to 1.1.11 now its broken :(

@owenniblock
Copy link
Member

We're working on this - although it's going to take us a while to get the fix out. In the meantime I recommend you work around it (as I believe you are working on) by manually specifying the file name.

@amchew
Copy link
Contributor

amchew commented Mar 6, 2019

Hi @dgobaud we fixed the bug in v1.1.12. Please upgrade to the latest version, and let us know if that works for you! I'll be closing this issue for now, but feel free to comment here/re-open this if you have any other questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants