Revert "Fixed an issue with contextual type for intersection properties" #50279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot cherry-pick this to release-4.8 |
|
Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into |
typescript-bot
added
the
For Uncommitted Bug
|
Hey @RyanCavanaugh, I've opened #50280 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 11, 2022
Component commits: eff4406 Revert "Fixed an issue with contextual type for intersection properties (microsoft#48668)" This reverts commit 9236e39.
|
Just an FYI @Andarist |
DanielRosenwasser
approved these changes
Aug 11, 2022
RyanCavanaugh
deleted the
revert-48668-contextual-type-function-obj-prop-intersection
branch
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Aug 15, 2022
…properties (microsoft#48668)" (microsoft#50279)" This reverts commit adf26ff.
typescript-bot
added a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 16, 2022
Component commits: eff4406 Revert "Fixed an issue with contextual type for intersection properties (microsoft#48668)" This reverts commit 9236e39. Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>
Andarist
added a commit
to Andarist/TypeScript
that referenced
this pull request
Jan 4, 2023
…properties (microsoft#48668)" (microsoft#50279)" This reverts commit adf26ff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #48668
This caused #49307 and we don't have a good mitigation for that break yet. Since the originating bug was not a regression, we'd like a fresh try on that bug which includes a testcase that replicates what's going on with
createSlice