Use node's algorithm for calculating the longest matching export/import pattern #49361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
DanielRosenwasser
approved these changes
Jun 2, 2022
andrewbranch
approved these changes
Jun 2, 2022
|
4.7.3? |
|
@typescript-bot cherry-pick this to release-4.7 |
|
Heya @weswigham, I've started to run the task to cherry-pick this into |
|
Hey @weswigham, I've opened #49364 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Jun 2, 2022
Component commits: fce9115 Use node's algorithm for calculating the longest matching export/import pattern
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jun 2, 2022
Component commits: fce9115 Use node's algorithm for calculating the longest matching export/import pattern Co-authored-by: Wesley Wigham <wewigham@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49308
Thanks to @PaperStrike for the research and initial tests - in addition to the sort just being backwards, node's sorting for pattern keys (
PATTERN_KEY_COMPAREin the resolution docs) is way more complex now that pattern trailers are a thing, and this sort was never updated to account for that, so now we just use node's algorithm pretty much verbatim.