Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hasOwn from Object instance to Object constructor #48207

Merged
merged 1 commit into from Mar 10, 2022
Merged

Move hasOwn from Object instance to Object constructor #48207

merged 1 commit into from Mar 10, 2022

Conversation

RyanCavanaugh
Copy link
Member

Fixes #48206

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 10, 2022
@DanielRosenwasser
Copy link
Member

🤦‍♂️

In checker.ts we have some logic for reporting whether or not the lib has to be adjusted for newer methods. Is that correct as well?

@DanielRosenwasser
Copy link
Member

Nah should be fine.

image

DanielRosenwasser
DanielRosenwasser approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we cherry-pick to release-4.6 and release a patch?

@RyanCavanaugh
Copy link
Member Author

I think so, this will not be the first report of it

@RyanCavanaugh
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.6

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 10, 2022 •
edited

Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into release-4.6 on this PR at d1b063e. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Mar 10, 2022
Merged
@typescript-bot
Copy link
Collaborator

Hey @RyanCavanaugh, I've opened #48213 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 10, 2022
@RyanCavanaugh
Cherry-pick PR microsoft#48207 into release-4.6
7ac565f 
Component commits:
d1b063e Move `hasOwn` from Object instance to Object constructor
Fixes microsoft#48206
@RyanCavanaugh RyanCavanaugh merged commit a4f5555 into microsoft:main Mar 10, 2022
@RyanCavanaugh RyanCavanaugh deleted the fixHasOwn branch March 10, 2022 23:31
DanielRosenwasser pushed a commit that referenced this pull request Mar 11, 2022
@typescript-bot @RyanCavanaugh
Cherry-pick PR #48207 into release-4.6 (#48213)
e397ed1 
Component commits:
d1b063e Move `hasOwn` from Object instance to Object constructor
Fixes #48206

Co-authored-by: Ryan Cavanaugh <ryanca@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@RyanCavanaugh RyanCavanaugh

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lib.es2022: hasOwn appears to be defined on Object prototype rather than on constructor
3 participants
@RyanCavanaugh @DanielRosenwasser @typescript-bot