Fix incorrect parser error assumption in semicolon handling leading to incremental parser brokenness #48067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o incremental parser brokenness
typescript-bot
added
Author: Team
For Milestone Bug
RyanCavanaugh
approved these changes
Mar 1, 2022
|
@typescript-bot cherry-pick this to release-4.6 |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
Hey @DanielRosenwasser, I've opened #48068 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 1, 2022
jakebailey
added a commit
that referenced
this pull request
Mar 1, 2022
…e-4.6 (#48068) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43005 added special handling for missing semicolons to attempt to produce better errors. Unfortunately, it made an incorrect assumption about when the tokenizer would have already reported an error. This led to a class node with a syntax error being created without the flag noting that it contained an error (there's an initializer, but there's not a brace after it), which then led to the incremental parser trying to use that node rather than deciding it was unsafe.
Just remove this assumption; this fixes the new test case, and only reverts one error change introduced in #43005 (which doesn't seem correct to me anyway).
Fixes #47895