Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for crash in navbar with double ambient modules #47395

Merged
merged 2 commits into from Jan 12, 2022
Merged

Fix for crash in navbar with double ambient modules #47395

merged 2 commits into from Jan 12, 2022

Conversation

DanielRosenwasser
Copy link
Member

Fixes #47394.
Fixes #38058.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 12, 2022
@DanielRosenwasser DanielRosenwasser merged commit 14f33d5 into main Jan 12, 2022
@DanielRosenwasser DanielRosenwasser deleted the navBarDoubleAmbientModule branch January 12, 2022 02:14
@DanielRosenwasser
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 13, 2022 •
edited

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.5 on this PR at 3ba8469. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Jan 13, 2022
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #47421 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Jan 13, 2022
@DanielRosenwasser
Cherry-pick PR microsoft#47395 into release-4.5
be6e153 
Component commits:
f230a5a Add failing test.

3ba8469 Guard against undefined module bodies in navbar/navtree.
DanielRosenwasser added a commit that referenced this pull request Jan 13, 2022
@typescript-bot @DanielRosenwasser
Cherry-pick PR #47395 into release-4.5 (#47421)
14016a7 
Component commits:
f230a5a Add failing test.

3ba8469 Guard against undefined module bodies in navbar/navtree.

Co-authored-by: Daniel Rosenwasser <drosen@microsoft.com>
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@gabritto gabritto Awaiting requested review from gabritto

Assignees

@DanielRosenwasser DanielRosenwasser

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
3 participants
@DanielRosenwasser @typescript-bot @jakebailey