Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checker initialization crash with esModuleInterop and global merges resolving to ImportEquals aliases #47348

Merged
merged 2 commits into from Jan 11, 2022
Merged

Fix checker initialization crash with esModuleInterop and global merges resolving to ImportEquals aliases #47348

merged 2 commits into from Jan 11, 2022

Conversation

andrewbranch
Copy link
Member

Fixes #47299

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 7, 2022
DanielRosenwasser
DanielRosenwasser approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an appropriate change. Thank you for finding the repro!

Longer-term, I would like to think through something that makes us resilient to the sort of ordering sensitivity we experienced here. Maybe the test case is enough for now, but ideally we would have a way to enforce discipline to avoid pulling on types before symbol merging has finished. Maybe @ahejlsberg has thoughts on this.

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 7, 2022 •
edited

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.5 on this PR at d52b9d3. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Jan 7, 2022
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #47349 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Jan 7, 2022
@andrewbranch
Cherry-pick PR microsoft#47348 into release-4.5
0de22ab 
Component commits:
755e1cb Add minimal failing test

d52b9d3 Fix checker initialization crash with esModuleInterop global merges resolving to ImportEquals aliases
@andrewbranch andrewbranch merged commit 852b1c2 into microsoft:main Jan 11, 2022
@andrewbranch andrewbranch deleted the bug/47299 branch January 11, 2022 00:04
This was referenced Jan 11, 2022
Closed
Closed
Closed
Closed
DanielRosenwasser pushed a commit that referenced this pull request Jan 12, 2022
@typescript-bot @andrewbranch
Cherry-pick PR #47348 into release-4.5 (#47349)
a5ebd53 
Component commits:
755e1cb Add minimal failing test

d52b9d3 Fix checker initialization crash with esModuleInterop global merges resolving to ImportEquals aliases

Co-authored-by: Andrew Branch <andrew@wheream.io>
@sandersn sandersn mentioned this pull request Jan 12, 2022
Closed
@kohtala kohtala mentioned this pull request Jan 17, 2022
Closed
@IllusionMH IllusionMH mentioned this pull request Jan 19, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@andrewbranch andrewbranch

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS Server fatal error: Cannot read property 'flags' of undefined
4 participants
@andrewbranch @DanielRosenwasser @typescript-bot @sandersn